Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing of empty attributes #39

Open
zlomek opened this issue Mar 12, 2019 · 0 comments
Open

Parsing of empty attributes #39

zlomek opened this issue Mar 12, 2019 · 0 comments

Comments

@zlomek
Copy link

zlomek commented Mar 12, 2019

While parsing an empty attribute, function parse_node_attributes() correctly creates a new attribute with value of length 0 but it sets the pointer into the buffer instead of to nullptr.
This does not harm in usual circumstances. But in case of cloning, it does. Then allocate_attribute() in clone_node() sets the value as value(val, internal::measure(val)) with length to the end of the buffer which is wrong.

Could you please check?

attribute->value(val, end - val);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant