Several smell-fixes

Author: bonigarcia

src/main/java/io/github/bonigarcia/wdm/WebDriverManager.java

@@ -170,7 +170,6 @@ public abstract class WebDriverManager {
     protected static final String CLI_RESOLVER = "resolveDriverFor";
     protected static final String CLI_DOCKER = "runInDocker";
     protected static final String BROWSER_WATCHER_ID = "kbnnckbeejhjlljpgelfponodpecfapp";
-    protected static final String BROWSER_WATCHER_ERROR = "This feature is not available in BrowserWatcher ";
 
     protected abstract List<URL> getDriverUrls(String driverVersion)
             throws IOException;
@@ -609,7 +608,8 @@ public WebDriverManager disableCsp() {
 
     protected void checkBrowserWatcherVersion() {
         if (getDriverManagerType() != FIREFOX) {
-            log.warn(BROWSER_WATCHER_ERROR + getBrowserWatcherVersion());
+            log.warn("This feature is not available in BrowserWatcher {}",
+                    getBrowserWatcherVersion());
         }
     }
 

src/main/java/io/github/bonigarcia/wdm/webdriver/Recording.java

@@ -32,6 +32,10 @@ public class Recording {
     private static final String SEPARATOR = "_";
     private static final String DATE_FORMAT = "yyyy.MM.dd_HH.mm.ss.SSS";
 
+    private Recording() {
+        throw new IllegalStateException("Utility class");
+    }
+
     public static String getRecordingName(String browserName,
             String sessionId) {
         Date now = new Date();

src/main/java/io/github/bonigarcia/wdm/webdriver/WebDriverBrowser.java

@@ -51,9 +51,9 @@ public class WebDriverBrowser {
 
     final Logger log = getLogger(lookup().lookupClass());
 
-    final String DEFAULT_DOWNLOADS_FOLDER = "Downloads";
-    final String LINUX_ENV_DOWNLOAD_DIR = "XDG_DOWNLOAD_DIR";
-    final String USER_HOME_PROPERTY = "user.home";
+    static final String DEFAULT_DOWNLOADS_FOLDER = "Downloads";
+    static final String LINUX_ENV_DOWNLOAD_DIR = "XDG_DOWNLOAD_DIR";
+    static final String USER_HOME_PROPERTY = "user.home";
     static final int RECORDING_TIMEOUT_SEC = 5;
     static final int POLL_TIME_MSEC = 500;
 
@@ -178,9 +178,8 @@ public Object executeJavaScript(String jsCommand) {
     }
 
     public void startRecording() {
-        String recordingName = Recording.getRecordingName(browserName,
-                ((RemoteWebDriver) driver).getSessionId().toString());
-        startRecording(recordingName);
+        startRecording(Recording.getRecordingName(browserName,
+                ((RemoteWebDriver) driver).getSessionId().toString()));
     }
 
     public void startRecording(String recordingName) {

src/test/java/io/github/bonigarcia/wdm/test/watcher/RecordChromeTest.java

@@ -54,7 +54,7 @@ void teardown() {
     }
 
     @Test
-    void test() throws InterruptedException {
+    void test() {
         driver.get(
                 "https://bonigarcia.dev/selenium-webdriver-java/slow-calculator.html");
 

src/test/java/io/github/bonigarcia/wdm/test/watcher/RecordEdgeTest.java

@@ -54,7 +54,7 @@ void teardown() {
     }
 
     @Test
-    void test() throws InterruptedException {
+    void test() {
         driver.get(
                 "https://bonigarcia.dev/selenium-webdriver-java/slow-calculator.html");