Commit 02f2e9c
committed
fix(node): loosen type of LoadFnOutput
A `LoadHook` accepts a `LoadHookContext` object having a `format` of `string | null | undefined`.
`LookHook` implementors often want to pass this value through ([example from docs](https://nodejs.org/api/module.html\#asynchronous-version), which suggests to me that a) it can be falsy, and b) it should be a looser type as established for `ResolveFnOutput` in DefinitelyTyped#71493).
A consequence of this is that `ModuleFormat` is no longer referenced anywhere; it can be removed.1 parent 56fa141 commit 02f2e9c
2 files changed
+9
-9
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
334 | 334 | | |
335 | 335 | | |
336 | 336 | | |
337 | | - | |
338 | | - | |
339 | | - | |
340 | | - | |
341 | | - | |
342 | | - | |
343 | | - | |
344 | | - | |
345 | 337 | | |
346 | 338 | | |
347 | 339 | | |
| |||
419 | 411 | | |
420 | 412 | | |
421 | 413 | | |
422 | | - | |
| 414 | + | |
423 | 415 | | |
424 | 416 | | |
425 | 417 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
204 | 204 | | |
205 | 205 | | |
206 | 206 | | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
207 | 215 | | |
208 | 216 | | |
209 | 217 | | |
| |||
0 commit comments