Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thumbnail should generate correct width and height filename #1675

Closed
I-Valchev opened this issue Aug 3, 2020 · 1 comment · Fixed by #1692
Closed

Thumbnail should generate correct width and height filename #1675

I-Valchev opened this issue Aug 3, 2020 · 1 comment · Fixed by #1692
Labels
🐛 tag: bug This is a bug.

Comments

@I-Valchev
Copy link
Member

the |thumbnail filter and thumbnail function allow the width or height to be omitted, so that the resizing is relative.

For example, source.jpg is 200x100

record|image|thumbnail(null, 50) returns /thumbs/320×50/stock/image_23532.jpg, BUT the width is actually relative (100)

The location should be /thumbs/100x50/stock/image_23532.jpg in this case.
@I-Valchev I-Valchev added the 🐛 tag: bug This is a bug. label Aug 3, 2020
@I-Valchev
Copy link
Member Author

@bobdenotter as discussed, this is a no-go. Thanks.

@I-Valchev I-Valchev reopened this Aug 6, 2020
@I-Valchev I-Valchev mentioned this issue Aug 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 tag: bug This is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Thumbnailing works with only width or only height bolt/core
1 participant
@I-Valchev