Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Half-star ratings are rounded up to the next int #325

Open
bohning opened this issue Dec 11, 2024 · 0 comments
Open

Half-star ratings are rounded up to the next int #325

bohning opened this issue Dec 11, 2024 · 0 comments
Milestone

Comments

@bohning
Copy link
Owner

bohning commented Dec 11, 2024

Song ratings are averaged to the nearest half star
image
but the Syncer rounds that up to the next integer.
The reason this happens is because we are counting the number of occurrences of star.png in the rating string, but this also matches half_star.png. Thus, this requires ratings to be either a float (currently an int), or use half stars as the base measure and then go from 0 to 10. There is a Unicode code point for LEFT HALF BLACK STAR (U+2BE8) that can be used.

@bohning bohning added this to the 1.0.0 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant