Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Fleet API and Proxy #127

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from
Draft

Support Fleet API and Proxy #127

wants to merge 19 commits into from

Conversation

andig
Copy link
Collaborator

@andig andig commented Feb 9, 2024

Fix #125

TODO

  • fix examples

@andig andig marked this pull request as draft February 9, 2024 16:18
@andig
Copy link
Collaborator Author

andig commented Feb 15, 2024

We‘re testing this against the proxy now.

@andig andig changed the title Drop vehicle ID Support Fleet API and Proxy Feb 19, 2024
client.go Outdated Show resolved Hide resolved
@andig
Copy link
Collaborator Author

andig commented Feb 21, 2024

@bogosj our first tests are positive now. Except for the examples this would be a good time to review the changes and make a decision if you want to continue hosting the module.
In terms of api I'm not super happy with the Set*Url methods but need them to switch between fleet api directly and proxy. In addition it would also be nice to swap the client for an existing vehicle (in case vehicle was retrieved reading from fleet api but one would like to send commands to using proxy).
Also worth noting that Powerwall still seems to support the owner api/ tokens.

@bogosj
Copy link
Owner

bogosj commented Feb 21, 2024

I have no objection to continuing to keep the library as bogosj/tesla. I'm probably not going to go to the effort to update my only use of this library, so I have no vested interest in keeping it alive. Perhaps it would be best with this major breaking change to take the opportunity to re-home it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support swap-in api replacement based on vehicle-command proxy like Tessi
2 participants