Skip to content

Commit ee6cb6c

Browse files
HyukjinKwonbogdanrdc
authored andcommitted
[SPARK-23698][PYTHON][FOLLOWUP] Resolve undefiend names in setup.py
## What changes were proposed in this pull request? `__version__` in `setup.py` is currently being dynamically read by `exec`; so the linter complains. Better just switch it off for this line for now. **Before:** ```bash $ python -m flake8 . --count --select=E9,F82 --show-source --statistics ./setup.py:37:11: F821 undefined name '__version__' VERSION = __version__ ^ 1 F821 undefined name '__version__' 1 ``` **After:** ```bash $ python -m flake8 . --count --select=E9,F82 --show-source --statistics 0 ``` ## How was this patch tested? Manually tested. Closes apache#22235 from HyukjinKwon/SPARK-23698. Authored-by: hyukjinkwon <[email protected]> Signed-off-by: hyukjinkwon <[email protected]>
1 parent b00824c commit ee6cb6c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

python/setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
print("Failed to load PySpark version file for packaging. You must be in Spark's python dir.",
3535
file=sys.stderr)
3636
sys.exit(-1)
37-
VERSION = __version__
37+
VERSION = __version__ # noqa
3838
# A temporary path so we can access above the Python project root and fetch scripts and jars we need
3939
TEMP_PATH = "deps"
4040
SPARK_HOME = os.path.abspath("../")

0 commit comments

Comments
 (0)