Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.1 compatibility #374

Open
jrfnl opened this issue Aug 7, 2021 · 3 comments · May be fixed by #421
Open

PHP 8.1 compatibility #374

jrfnl opened this issue Aug 7, 2021 · 3 comments · May be fixed by #421

Comments

@jrfnl
Copy link

jrfnl commented Aug 7, 2021 •
edited
Loading

Hiya!

I just noticed some PHP 8.1 notices related to Mustache for a repo where this package is a dependency of a dependency ;-)

While I'd love to send in some PRs to fix things, but that would require to first get the tests running on PHP 8.1.

Looking at the current setup, I see the following issues:

  • CI still on Travis, while Travis is effectively dead for open source.
    👉🏻 Would a PR to switch the existing Travis script over to GH Actions be welcome ?
  • PHPUnit limited to "~3.7|~4.0|~5.0".
    Making the tests PHP/PHPUnit cross version compatible to include PHP 8.x with those version constraints is going to be exceedingly hard.
    There is a PHPUnit Polyfills package available which will allow an upgrade to the tests to use PHPUnit 9.x assertions and expectations and get round the PHPUnit 8.x void issue, while still being able to run the tests all the way back to PHPUnit 4.x, but that package requires a minimum PHP version of PHP 5.4, while this package still requires PHP 5.2.

I'd love some guidance on how to proceed.
@jrfnl
Copy link
Author

jrfnl commented Aug 7, 2021

Another thing I noticed: in the Travis script, it gives the impression that HHVM is still supported. Is this really true ?

@jrfnl
Copy link
Author

jrfnl commented Aug 7, 2021 •
edited
Loading

Some quick testing/investigating shows me that the fabpot/yaml test dependency which is pulled in via a submodule is not (fully) compatible with PHP 8.0. As that package is abandoned, that won't be fixed anymore, so a solution for this will also need to be found.

@andrewnicols
Copy link

Pinging @bobthecow on this issue. There's still no movement towards PHP 8.X support, and with PHP 8.4 support just around the corner it would be great to get some direction here.

Is this project still maintained? Would you be interested in some help in maintaining it so we can add the necessary PHP 8 support without being forced to fork?

@swissspidy swissspidy linked a pull request Nov 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve PHP 8 compatibility and testing swissspidy/mustache.php
2 participants
@andrewnicols @jrfnl