Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check command line param for CI #71

Closed
dessalines opened this issue Apr 5, 2023 · 3 comments
Closed

Add a check command line param for CI #71

dessalines opened this issue Apr 5, 2023 · 3 comments

Comments

@dessalines
Copy link

This would be nice to have, then we could have it fail on our CI if someone added a dependency that is actually unused.

@dessalines dessalines changed the title Add a check command line paran for CI Add a ´check´ command line paran for CI Apr 5, 2023
@dessalines dessalines changed the title Add a ´check´ command line paran for CI Add a check command line param for CI Apr 5, 2023
@bnjbvr
Copy link
Owner

bnjbvr commented Apr 5, 2023

Hi! cargo machete will return a status code if any unused dependencies have been found:

  • 1 if there was at least one unused dependency
  • 2 if there was an error during processing

Is this something you could use?

I think we could document this a bit better, and also just set up our github action so people can use this more easily.

@dessalines
Copy link
Author

Ah okay, I didn't realize it returned proper status codes, that should work fine already then. Thanks!

@bnjbvr
Copy link
Owner

bnjbvr commented Apr 6, 2023

I've added #72 which tweaks the README to let users of machete know about the return code. I'll investigate the Github action later, would be nice to have too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants