-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Would be even more awesome with system requirements by package #258
Comments
Yes we need to improve that. It could be a lot of work to test existing plugins. How can we handle this? We can contact plugins author, but we should offer a way to make easy for the Community to help. |
I wouldn't mind contributing along these lines if there was an obvious way to mark comparability requirements. Low tech is fine, even just a note on the row or additional column with OS icons would work. Ideally the package authors would note OS requirements in their own package.json... Maybe compat PRs to this list should point back to either an OS declaration in the plugin's package.json or a PR for the same? |
Love this idea, and it looks like that's a damn solid implementation. I have two concerns, neither of which are hard blockers, but something we should consider:
|
The best example is the last approved plugin which has a disclaimer about working only on MacOS directly in its README. But you're right, it is a change with potential big impacts that need to be carefully weighed. |
That looks very nice! Some thoughts: Plugins can declare OS dependencies in their package.json, e.g. I submitted this PR to hyper-statusline a little while back. It's likely not very well maintained but could be useful for auto-generating the initial info. Could also help in future to flag package changes for compatibility review. I'd suggest PR's here could point back to either issues or PR's noting/fixing/reporting compat issues for the package in question. You could take a hard line and completely derive your compat data from that field and then just redirect folks to hound package authors to correctly declare their OS compatibility. Aside from something along those lines I feel like relying on the community to keep the list up to date is your best bet. |
You are right, we should use (and encourage) OS compatibility declaration in their package.json. With my OS proposal, writing a row is hard with all these elements : name, description, OS badges and download badge. To make PR easier, I made a little tool to automatically format this row: https://awesome-hyper-linkmaker.now.sh It takes description AND os-compatibility from NPMJS (so, from We can maybe add a warning when user modify os-compatibility to encourage him to add/update it to its I have no idea how to have feedbacks from community to keep this list up-to-date without a real website. Issues can be opened but it doesn't seems user-friendly. |
I think GitHub issues would be a 👌 way to get feedback - if you try to download/use a module and it's not supported on the platform that I think the way to implement this would be to simply put a boilerplate paragraph in front of each section that states supported OS is community-maintained, and if you find that it's not accurate you can open an issue and we'll update. |
For example, a number of these (
hypercwd
andhyper-statusline
to name a couple) don't work on Windows and their authors have no plans to add support. This makes for a pretty not-awesome experience for the plucky Windows user going down this list installing plugins :(.The text was updated successfully, but these errors were encountered: