Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize the logic ReorgNeeded, too much logic operation now #2601

Closed
NathanBSC opened this issue Jul 22, 2024 · 0 comments
Closed

optimize the logic ReorgNeeded, too much logic operation now #2601

NathanBSC opened this issue Jul 22, 2024 · 0 comments
Assignees
@buddh0

Comments

@NathanBSC
Copy link
Contributor

Rationale

reorg = !currentPreserve && (externPreserve ||
			extern.Time < current.Time ||
			extern.Time == current.Time &&
				((doubleSign && extern.Hash().Cmp(current.Hash()) < 0) ||
					(!doubleSign && f.rand.Float64() < 0.5)))

optimize the logic ReorgNeeded, too much logic operation now

Implementation

Do you have ideas regarding the implementation of this feature?
Are you willing to implement this feature?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@buddh0 buddh0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@buddh0 @NathanBSC