Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question regarding pbss and pruning #2555

Closed
zhk101 opened this issue Jun 30, 2024 · 3 comments
Closed

Question regarding pbss and pruning #2555

zhk101 opened this issue Jun 30, 2024 · 3 comments
Assignees

Comments

@zhk101
Copy link

zhk101 commented Jun 30, 2024

A few weeks back I read some issues related to pruning not working anymore or causing issues with the latest version of geth.
I've recently saw some commit around fixing pruning (eg: #2481).
Also read (https://www.bnbchain.org/en/blog/optimizing-blockchain-storage-bscs-path-based-storage-system) that PBSS, introduced in BSC's V1.3.1-beta release, addresses these concerns by introducing an online state prune feature

My node is using a path-based (pbss) snapshot from bnb48. I've removed a while ago the prunestate parameter to my node startup params.
Can it be added back now? Is it still needed? Also, if a node has been running for long without that flag, can it be added later on and would it prune its backlog?

@zzzckck
Copy link
Collaborator

zzzckck commented Jul 1, 2024

I've removed a while ago the prunestate parameter to my node startup params.

====
what is the params? do you mean "--pruneancient"?

@zzzckck zzzckck self-assigned this Jul 1, 2024
@zhk101
Copy link
Author

zhk101 commented Jul 1, 2024

what is the params? do you mean "--pruneancient"?

yes, that one

@zzzckck
Copy link
Collaborator

zzzckck commented Jul 2, 2024

what is the params? do you mean "--pruneancient"?

yes, that one

There is some potential issue regarding to this flag: "--pruneancient", we are working on it, better not use this flag right now.
But for nodes that are already running with flag, it is fine, no need to switch it off.

@zhk101 zhk101 closed this as completed Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants