Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: remove flag --chapel #2521

Closed
zzzckck opened this issue Jun 20, 2024 · 1 comment
Closed

UX: remove flag --chapel #2521

zzzckck opened this issue Jun 20, 2024 · 1 comment
Assignees

Comments

@zzzckck
Copy link
Collaborator

zzzckck commented Jun 20, 2024

Rationale

network can be read from the config.toml file, seems no need to add this extra flag.

Implementation

NA

@zzzckck zzzckck assigned zzzckck and buddh0 and unassigned zzzckck Jun 24, 2024
@buddh0
Copy link
Collaborator

buddh0 commented Jul 9, 2024

Rationale

network can be read from the config.toml file, seems no need to add this extra flag.

Implementation

NA

some commands not support using config.toml
such as importHistory

other few scenarios, some actions happened before reading config.toml
such as func prepare(ctx *cli.Context)

and in addition, '--chapel' is totally following the geth

	NetworkIdFlag = &cli.Uint64Flag{
		Name:     "networkid",
		Usage:    "Explicitly set network id (integer)(For testnets: use --goerli, --sepolia, --holesky instead)",
		Value:    ethconfig.Defaults.NetworkId,
		Category: flags.EthCategory,
	}

I think we can support removing '--chapel' and read the networkId from config.toml when we do a sync,
but not removing --chapel totally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants