Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

failed to pass unit test: bsc/cmd/geth/pruneblock_test.go #1046

Closed
wangtsiao opened this issue Aug 11, 2022 · 1 comment
Closed

failed to pass unit test: bsc/cmd/geth/pruneblock_test.go #1046

wangtsiao opened this issue Aug 11, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@wangtsiao
Copy link

I found maxFeePerGas and baseFee fields are not adopted in bsc when i recently reading reposity.

so why not remove this baseFee check in unit tests?

--- FAIL: TestOfflineBlockPrune (0.06s)
panic: max fee per gas less than block base fee: address 0x71562b71999873DB5b286dF957af199Ec94617F7, maxFeePerGas: 0 baseFee: 875000000 [recovered]
        panic: max fee per gas less than block base fee: address 0x71562b71999873DB5b286dF957af199Ec94617F7, maxFeePerGas: 0 baseFee: 875000000
@j75689
Copy link
Contributor

j75689 commented Aug 17, 2022

maxFeePerGas and baseFee is merged from go-ethereum, if it is to be completely removed, it will require relatively large changes, and there are no plans to do so at the moment

But we can fix this uint-test

@j75689 j75689 added the bug Something isn't working label Aug 17, 2022
@j75689 j75689 mentioned this issue Aug 22, 2022
Merged
@j75689 j75689 closed this as completed Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@j75689 @wangtsiao