Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call Handling and Configure popups show incorrect information with version 4.4.0 #1222

Closed
alanb2718 opened this issue Nov 4, 2024 · 6 comments
Labels

Comments

@alanb2718
Copy link
Collaborator

The Call Handling and Configure popups are showing incorrect information with yap version 4.4.0 for the WSZF yap server.

But (yay!) it looks like this is fixed with 4.4.1-beta.

To verify, my suggestion is to see if you can reproduce this bug (details below), and then verify that 4.4.1-beta fixes this issue as well as volunteer groups (issue #1194, which was what the beta was about).

If that checks out, update the release notes from Fix for editing groups. to Fix for editing groups, Call Handling, and Configure popups. Hopefully you don't need to do anything else.

I am also hoping that this is just a bug in how the information in the popups is displayed, and that the database isn't corrupted in any way by the bug.

Here are some details.

For the Call Handling tab, with 4.4.0, Helpline Routing says "Helpline Field Number" even though it's actually "Volunteers" in the database. The entries for Gender Routing, Call Strategy, and Inbound call SMS to Volunteer are missing entirely, even though that information is also in the database still.

For the Configure tab, rather than the actual configuration, it shows the volunteer information for the first volunteer on the volunteer list. (Since this includes personal information I don't want to include a screen shot.)

We are using PHP version 8.1.29

These tabs were working on with yap 4.3.5. We didn't notice this before, since we didn't have any new service bodies starting to use the zone's server and nobody tried updating their configuration.

@alanb2718 alanb2718 added the bug label Nov 4, 2024
@dgershman
Copy link
Collaborator

Can you email me a copy of your database?

@alanb2718
Copy link
Collaborator Author

OK, done.

@dgershman
Copy link
Collaborator

I'm not seeing any data corruption in your database. The schemas seem to match the data types.

@alanb2718
Copy link
Collaborator Author

That's reassuring. What about what you see when you open a Call Handling or Configure popup? Is this an issue only with the WSZF data, or does this happen on any yap 4.4.0 server?

@dgershman
Copy link
Collaborator

It looks like a widespread 4.4.0 issue that no one else reported.

@dgershman
Copy link
Collaborator

There are now (as of 4.4.1) separate API calls for each data type. This change was long overdue. Also cypress tests have been added for each screen as well, which should catch this from happening in the ftuure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants