Improve error name and message for signed-in only feeds#6577
Merged
Conversation
estrattonbailey
changed the title
Contributor
|
pfrazee
reviewed
Nov 20, 2024
pfrazee
approved these changes
Nov 20, 2024
pfrazee
left a comment
pfrazee
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, one small tweak
arcalinea
temporarily deployed
to
improve-nsfpublic - social-app PR #6577
Render
Destroyed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When viewing a feed as a signed-out visitor to our web app, we check pages of posts to see if any posts pass the default signed-out moderation settings. If none pass, we show an error screen in place of an entirely empty feed. We do this to prevent endless frontend fetching, trying to find a full page (30) posts that pass moderation and can be shown to the public.
Important to note:
no-unauthenticatedlabels on users are also caught by this moderation check, meaning if a feed is full of folks who have opted out of public views, we will also show this error screen on the feed.The previous error name and copy was a little misleading, and maybe concerning to some users. This PR aims to make it a little more clear what's happening. In the future we should revisit how we handle this "error" state.