From 4ddaefdb4b74126dfeb3bb4da57c2e7c4634f8ea Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Tue, 10 Dec 2024 18:58:57 +0000 Subject: [PATCH 1/6] Add filter param to listNotifications --- lexicons/app/bsky/notification/listNotifications.json | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lexicons/app/bsky/notification/listNotifications.json b/lexicons/app/bsky/notification/listNotifications.json index c85a516723d..f3abe5139d0 100644 --- a/lexicons/app/bsky/notification/listNotifications.json +++ b/lexicons/app/bsky/notification/listNotifications.json @@ -8,6 +8,12 @@ "parameters": { "type": "params", "properties": { + "filter": { + "type": "string", + "description": "Notification types to include in response.", + "knownValues": ["all", "mentions"], + "default": "all" + }, "limit": { "type": "integer", "minimum": 1, From c7644d88ff436377a3db6961c45d606dfb8f22c5 Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Tue, 10 Dec 2024 19:00:51 +0000 Subject: [PATCH 2/6] Codegen --- packages/api/src/client/lexicons.ts | 6 ++++++ .../client/types/app/bsky/notification/listNotifications.ts | 2 ++ packages/bsky/src/lexicon/lexicons.ts | 6 ++++++ .../types/app/bsky/notification/listNotifications.ts | 2 ++ packages/ozone/src/lexicon/lexicons.ts | 6 ++++++ .../types/app/bsky/notification/listNotifications.ts | 2 ++ packages/pds/src/lexicon/lexicons.ts | 6 ++++++ .../types/app/bsky/notification/listNotifications.ts | 2 ++ 8 files changed, 32 insertions(+) diff --git a/packages/api/src/client/lexicons.ts b/packages/api/src/client/lexicons.ts index 954fc444c0e..f3c63904158 100644 --- a/packages/api/src/client/lexicons.ts +++ b/packages/api/src/client/lexicons.ts @@ -8944,6 +8944,12 @@ export const schemaDict = { parameters: { type: 'params', properties: { + filter: { + type: 'string', + description: 'Notification types to include in response.', + knownValues: ['all', 'mentions'], + default: 'all', + }, limit: { type: 'integer', minimum: 1, diff --git a/packages/api/src/client/types/app/bsky/notification/listNotifications.ts b/packages/api/src/client/types/app/bsky/notification/listNotifications.ts index 10a5b7148f2..cf935a8b625 100644 --- a/packages/api/src/client/types/app/bsky/notification/listNotifications.ts +++ b/packages/api/src/client/types/app/bsky/notification/listNotifications.ts @@ -10,6 +10,8 @@ import * as AppBskyActorDefs from '../actor/defs' import * as ComAtprotoLabelDefs from '../../../com/atproto/label/defs' export interface QueryParams { + /** Notification types to include in response. */ + filter?: 'all' | 'mentions' | (string & {}) limit?: number priority?: boolean cursor?: string diff --git a/packages/bsky/src/lexicon/lexicons.ts b/packages/bsky/src/lexicon/lexicons.ts index 4a2fad8d587..4b7e3c3dd44 100644 --- a/packages/bsky/src/lexicon/lexicons.ts +++ b/packages/bsky/src/lexicon/lexicons.ts @@ -8944,6 +8944,12 @@ export const schemaDict = { parameters: { type: 'params', properties: { + filter: { + type: 'string', + description: 'Notification types to include in response.', + knownValues: ['all', 'mentions'], + default: 'all', + }, limit: { type: 'integer', minimum: 1, diff --git a/packages/bsky/src/lexicon/types/app/bsky/notification/listNotifications.ts b/packages/bsky/src/lexicon/types/app/bsky/notification/listNotifications.ts index 70adc412701..31066ac9499 100644 --- a/packages/bsky/src/lexicon/types/app/bsky/notification/listNotifications.ts +++ b/packages/bsky/src/lexicon/types/app/bsky/notification/listNotifications.ts @@ -11,6 +11,8 @@ import * as AppBskyActorDefs from '../actor/defs' import * as ComAtprotoLabelDefs from '../../../com/atproto/label/defs' export interface QueryParams { + /** Notification types to include in response. */ + filter: 'all' | 'mentions' | (string & {}) limit: number priority?: boolean cursor?: string diff --git a/packages/ozone/src/lexicon/lexicons.ts b/packages/ozone/src/lexicon/lexicons.ts index 954fc444c0e..f3c63904158 100644 --- a/packages/ozone/src/lexicon/lexicons.ts +++ b/packages/ozone/src/lexicon/lexicons.ts @@ -8944,6 +8944,12 @@ export const schemaDict = { parameters: { type: 'params', properties: { + filter: { + type: 'string', + description: 'Notification types to include in response.', + knownValues: ['all', 'mentions'], + default: 'all', + }, limit: { type: 'integer', minimum: 1, diff --git a/packages/ozone/src/lexicon/types/app/bsky/notification/listNotifications.ts b/packages/ozone/src/lexicon/types/app/bsky/notification/listNotifications.ts index 70adc412701..31066ac9499 100644 --- a/packages/ozone/src/lexicon/types/app/bsky/notification/listNotifications.ts +++ b/packages/ozone/src/lexicon/types/app/bsky/notification/listNotifications.ts @@ -11,6 +11,8 @@ import * as AppBskyActorDefs from '../actor/defs' import * as ComAtprotoLabelDefs from '../../../com/atproto/label/defs' export interface QueryParams { + /** Notification types to include in response. */ + filter: 'all' | 'mentions' | (string & {}) limit: number priority?: boolean cursor?: string diff --git a/packages/pds/src/lexicon/lexicons.ts b/packages/pds/src/lexicon/lexicons.ts index 954fc444c0e..f3c63904158 100644 --- a/packages/pds/src/lexicon/lexicons.ts +++ b/packages/pds/src/lexicon/lexicons.ts @@ -8944,6 +8944,12 @@ export const schemaDict = { parameters: { type: 'params', properties: { + filter: { + type: 'string', + description: 'Notification types to include in response.', + knownValues: ['all', 'mentions'], + default: 'all', + }, limit: { type: 'integer', minimum: 1, diff --git a/packages/pds/src/lexicon/types/app/bsky/notification/listNotifications.ts b/packages/pds/src/lexicon/types/app/bsky/notification/listNotifications.ts index 70adc412701..31066ac9499 100644 --- a/packages/pds/src/lexicon/types/app/bsky/notification/listNotifications.ts +++ b/packages/pds/src/lexicon/types/app/bsky/notification/listNotifications.ts @@ -11,6 +11,8 @@ import * as AppBskyActorDefs from '../actor/defs' import * as ComAtprotoLabelDefs from '../../../com/atproto/label/defs' export interface QueryParams { + /** Notification types to include in response. */ + filter: 'all' | 'mentions' | (string & {}) limit: number priority?: boolean cursor?: string From 415a35924f847201c653cd1cebb51f1978ad8d7f Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Tue, 10 Dec 2024 19:02:04 +0000 Subject: [PATCH 3/6] Changeset --- .changeset/stupid-feet-allow.md | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 .changeset/stupid-feet-allow.md diff --git a/.changeset/stupid-feet-allow.md b/.changeset/stupid-feet-allow.md new file mode 100644 index 00000000000..d8e892933c1 --- /dev/null +++ b/.changeset/stupid-feet-allow.md @@ -0,0 +1,8 @@ +--- +"@atproto/ozone": patch +"@atproto/bsky": patch +"@atproto/api": patch +"@atproto/pds": patch +--- + +Add optional filter param to listNotifications From 219582bb2bb260eb492905c5360b9f95a0bedccd Mon Sep 17 00:00:00 2001 From: dholms Date: Tue, 10 Dec 2024 14:39:55 -0600 Subject: [PATCH 4/6] update schemas --- .../app/bsky/notification/listNotifications.json | 16 +++++++++++++--- packages/api/src/client/lexicons.ts | 16 +++++++++++++--- .../app/bsky/notification/listNotifications.ts | 10 +++++++++- packages/bsky/src/lexicon/lexicons.ts | 16 +++++++++++++--- .../app/bsky/notification/listNotifications.ts | 10 +++++++++- packages/ozone/src/lexicon/lexicons.ts | 16 +++++++++++++--- .../app/bsky/notification/listNotifications.ts | 10 +++++++++- packages/pds/src/lexicon/lexicons.ts | 16 +++++++++++++--- .../app/bsky/notification/listNotifications.ts | 10 +++++++++- 9 files changed, 101 insertions(+), 19 deletions(-) diff --git a/lexicons/app/bsky/notification/listNotifications.json b/lexicons/app/bsky/notification/listNotifications.json index f3abe5139d0..eac2dc9bba7 100644 --- a/lexicons/app/bsky/notification/listNotifications.json +++ b/lexicons/app/bsky/notification/listNotifications.json @@ -9,10 +9,20 @@ "type": "params", "properties": { "filter": { - "type": "string", "description": "Notification types to include in response.", - "knownValues": ["all", "mentions"], - "default": "all" + "type": "array", + "items": { + "type": "string", + "knownValues": [ + "like", + "repost", + "follow", + "mention", + "reply", + "quote", + "starterpack-joined" + ] + } }, "limit": { "type": "integer", diff --git a/packages/api/src/client/lexicons.ts b/packages/api/src/client/lexicons.ts index f3c63904158..5ee7cd3d424 100644 --- a/packages/api/src/client/lexicons.ts +++ b/packages/api/src/client/lexicons.ts @@ -8945,10 +8945,20 @@ export const schemaDict = { type: 'params', properties: { filter: { - type: 'string', description: 'Notification types to include in response.', - knownValues: ['all', 'mentions'], - default: 'all', + type: 'array', + items: { + type: 'string', + knownValues: [ + 'like', + 'repost', + 'follow', + 'mention', + 'reply', + 'quote', + 'starterpack-joined', + ], + }, }, limit: { type: 'integer', diff --git a/packages/api/src/client/types/app/bsky/notification/listNotifications.ts b/packages/api/src/client/types/app/bsky/notification/listNotifications.ts index cf935a8b625..be4a2e758d8 100644 --- a/packages/api/src/client/types/app/bsky/notification/listNotifications.ts +++ b/packages/api/src/client/types/app/bsky/notification/listNotifications.ts @@ -11,7 +11,15 @@ import * as ComAtprotoLabelDefs from '../../../com/atproto/label/defs' export interface QueryParams { /** Notification types to include in response. */ - filter?: 'all' | 'mentions' | (string & {}) + filter?: + | 'like' + | 'repost' + | 'follow' + | 'mention' + | 'reply' + | 'quote' + | 'starterpack-joined' + | (string & {})[] limit?: number priority?: boolean cursor?: string diff --git a/packages/bsky/src/lexicon/lexicons.ts b/packages/bsky/src/lexicon/lexicons.ts index 4b7e3c3dd44..12c20ad858f 100644 --- a/packages/bsky/src/lexicon/lexicons.ts +++ b/packages/bsky/src/lexicon/lexicons.ts @@ -8945,10 +8945,20 @@ export const schemaDict = { type: 'params', properties: { filter: { - type: 'string', description: 'Notification types to include in response.', - knownValues: ['all', 'mentions'], - default: 'all', + type: 'array', + items: { + type: 'string', + knownValues: [ + 'like', + 'repost', + 'follow', + 'mention', + 'reply', + 'quote', + 'starterpack-joined', + ], + }, }, limit: { type: 'integer', diff --git a/packages/bsky/src/lexicon/types/app/bsky/notification/listNotifications.ts b/packages/bsky/src/lexicon/types/app/bsky/notification/listNotifications.ts index 31066ac9499..32cd7dcc797 100644 --- a/packages/bsky/src/lexicon/types/app/bsky/notification/listNotifications.ts +++ b/packages/bsky/src/lexicon/types/app/bsky/notification/listNotifications.ts @@ -12,7 +12,15 @@ import * as ComAtprotoLabelDefs from '../../../com/atproto/label/defs' export interface QueryParams { /** Notification types to include in response. */ - filter: 'all' | 'mentions' | (string & {}) + filter?: + | 'like' + | 'repost' + | 'follow' + | 'mention' + | 'reply' + | 'quote' + | 'starterpack-joined' + | (string & {})[] limit: number priority?: boolean cursor?: string diff --git a/packages/ozone/src/lexicon/lexicons.ts b/packages/ozone/src/lexicon/lexicons.ts index f3c63904158..5ee7cd3d424 100644 --- a/packages/ozone/src/lexicon/lexicons.ts +++ b/packages/ozone/src/lexicon/lexicons.ts @@ -8945,10 +8945,20 @@ export const schemaDict = { type: 'params', properties: { filter: { - type: 'string', description: 'Notification types to include in response.', - knownValues: ['all', 'mentions'], - default: 'all', + type: 'array', + items: { + type: 'string', + knownValues: [ + 'like', + 'repost', + 'follow', + 'mention', + 'reply', + 'quote', + 'starterpack-joined', + ], + }, }, limit: { type: 'integer', diff --git a/packages/ozone/src/lexicon/types/app/bsky/notification/listNotifications.ts b/packages/ozone/src/lexicon/types/app/bsky/notification/listNotifications.ts index 31066ac9499..32cd7dcc797 100644 --- a/packages/ozone/src/lexicon/types/app/bsky/notification/listNotifications.ts +++ b/packages/ozone/src/lexicon/types/app/bsky/notification/listNotifications.ts @@ -12,7 +12,15 @@ import * as ComAtprotoLabelDefs from '../../../com/atproto/label/defs' export interface QueryParams { /** Notification types to include in response. */ - filter: 'all' | 'mentions' | (string & {}) + filter?: + | 'like' + | 'repost' + | 'follow' + | 'mention' + | 'reply' + | 'quote' + | 'starterpack-joined' + | (string & {})[] limit: number priority?: boolean cursor?: string diff --git a/packages/pds/src/lexicon/lexicons.ts b/packages/pds/src/lexicon/lexicons.ts index f3c63904158..5ee7cd3d424 100644 --- a/packages/pds/src/lexicon/lexicons.ts +++ b/packages/pds/src/lexicon/lexicons.ts @@ -8945,10 +8945,20 @@ export const schemaDict = { type: 'params', properties: { filter: { - type: 'string', description: 'Notification types to include in response.', - knownValues: ['all', 'mentions'], - default: 'all', + type: 'array', + items: { + type: 'string', + knownValues: [ + 'like', + 'repost', + 'follow', + 'mention', + 'reply', + 'quote', + 'starterpack-joined', + ], + }, }, limit: { type: 'integer', diff --git a/packages/pds/src/lexicon/types/app/bsky/notification/listNotifications.ts b/packages/pds/src/lexicon/types/app/bsky/notification/listNotifications.ts index 31066ac9499..32cd7dcc797 100644 --- a/packages/pds/src/lexicon/types/app/bsky/notification/listNotifications.ts +++ b/packages/pds/src/lexicon/types/app/bsky/notification/listNotifications.ts @@ -12,7 +12,15 @@ import * as ComAtprotoLabelDefs from '../../../com/atproto/label/defs' export interface QueryParams { /** Notification types to include in response. */ - filter: 'all' | 'mentions' | (string & {}) + filter?: + | 'like' + | 'repost' + | 'follow' + | 'mention' + | 'reply' + | 'quote' + | 'starterpack-joined' + | (string & {})[] limit: number priority?: boolean cursor?: string From 3239b5f9ebe411367d51bcc4300cb7e3f7fb23b7 Mon Sep 17 00:00:00 2001 From: dholms Date: Tue, 10 Dec 2024 16:46:43 -0600 Subject: [PATCH 5/6] tweak schema --- lexicons/app/bsky/notification/listNotifications.json | 10 +--------- packages/api/src/client/lexicons.ts | 11 ++--------- .../types/app/bsky/notification/listNotifications.ts | 10 +--------- packages/bsky/src/lexicon/lexicons.ts | 11 ++--------- .../types/app/bsky/notification/listNotifications.ts | 10 +--------- packages/ozone/src/lexicon/lexicons.ts | 11 ++--------- .../types/app/bsky/notification/listNotifications.ts | 10 +--------- packages/pds/src/lexicon/lexicons.ts | 11 ++--------- .../types/app/bsky/notification/listNotifications.ts | 10 +--------- 9 files changed, 13 insertions(+), 81 deletions(-) diff --git a/lexicons/app/bsky/notification/listNotifications.json b/lexicons/app/bsky/notification/listNotifications.json index eac2dc9bba7..65d35195c7b 100644 --- a/lexicons/app/bsky/notification/listNotifications.json +++ b/lexicons/app/bsky/notification/listNotifications.json @@ -13,15 +13,7 @@ "type": "array", "items": { "type": "string", - "knownValues": [ - "like", - "repost", - "follow", - "mention", - "reply", - "quote", - "starterpack-joined" - ] + "description": "A reason that matches the reason property of #notification." } }, "limit": { diff --git a/packages/api/src/client/lexicons.ts b/packages/api/src/client/lexicons.ts index 5ee7cd3d424..f3cbd252cbf 100644 --- a/packages/api/src/client/lexicons.ts +++ b/packages/api/src/client/lexicons.ts @@ -8949,15 +8949,8 @@ export const schemaDict = { type: 'array', items: { type: 'string', - knownValues: [ - 'like', - 'repost', - 'follow', - 'mention', - 'reply', - 'quote', - 'starterpack-joined', - ], + description: + 'A reason that matches the reason property of #notification.', }, }, limit: { diff --git a/packages/api/src/client/types/app/bsky/notification/listNotifications.ts b/packages/api/src/client/types/app/bsky/notification/listNotifications.ts index be4a2e758d8..dd692a190ed 100644 --- a/packages/api/src/client/types/app/bsky/notification/listNotifications.ts +++ b/packages/api/src/client/types/app/bsky/notification/listNotifications.ts @@ -11,15 +11,7 @@ import * as ComAtprotoLabelDefs from '../../../com/atproto/label/defs' export interface QueryParams { /** Notification types to include in response. */ - filter?: - | 'like' - | 'repost' - | 'follow' - | 'mention' - | 'reply' - | 'quote' - | 'starterpack-joined' - | (string & {})[] + filter?: string[] limit?: number priority?: boolean cursor?: string diff --git a/packages/bsky/src/lexicon/lexicons.ts b/packages/bsky/src/lexicon/lexicons.ts index 12c20ad858f..52072d15014 100644 --- a/packages/bsky/src/lexicon/lexicons.ts +++ b/packages/bsky/src/lexicon/lexicons.ts @@ -8949,15 +8949,8 @@ export const schemaDict = { type: 'array', items: { type: 'string', - knownValues: [ - 'like', - 'repost', - 'follow', - 'mention', - 'reply', - 'quote', - 'starterpack-joined', - ], + description: + 'A reason that matches the reason property of #notification.', }, }, limit: { diff --git a/packages/bsky/src/lexicon/types/app/bsky/notification/listNotifications.ts b/packages/bsky/src/lexicon/types/app/bsky/notification/listNotifications.ts index 32cd7dcc797..56595f0da7d 100644 --- a/packages/bsky/src/lexicon/types/app/bsky/notification/listNotifications.ts +++ b/packages/bsky/src/lexicon/types/app/bsky/notification/listNotifications.ts @@ -12,15 +12,7 @@ import * as ComAtprotoLabelDefs from '../../../com/atproto/label/defs' export interface QueryParams { /** Notification types to include in response. */ - filter?: - | 'like' - | 'repost' - | 'follow' - | 'mention' - | 'reply' - | 'quote' - | 'starterpack-joined' - | (string & {})[] + filter?: string[] limit: number priority?: boolean cursor?: string diff --git a/packages/ozone/src/lexicon/lexicons.ts b/packages/ozone/src/lexicon/lexicons.ts index 5ee7cd3d424..f3cbd252cbf 100644 --- a/packages/ozone/src/lexicon/lexicons.ts +++ b/packages/ozone/src/lexicon/lexicons.ts @@ -8949,15 +8949,8 @@ export const schemaDict = { type: 'array', items: { type: 'string', - knownValues: [ - 'like', - 'repost', - 'follow', - 'mention', - 'reply', - 'quote', - 'starterpack-joined', - ], + description: + 'A reason that matches the reason property of #notification.', }, }, limit: { diff --git a/packages/ozone/src/lexicon/types/app/bsky/notification/listNotifications.ts b/packages/ozone/src/lexicon/types/app/bsky/notification/listNotifications.ts index 32cd7dcc797..56595f0da7d 100644 --- a/packages/ozone/src/lexicon/types/app/bsky/notification/listNotifications.ts +++ b/packages/ozone/src/lexicon/types/app/bsky/notification/listNotifications.ts @@ -12,15 +12,7 @@ import * as ComAtprotoLabelDefs from '../../../com/atproto/label/defs' export interface QueryParams { /** Notification types to include in response. */ - filter?: - | 'like' - | 'repost' - | 'follow' - | 'mention' - | 'reply' - | 'quote' - | 'starterpack-joined' - | (string & {})[] + filter?: string[] limit: number priority?: boolean cursor?: string diff --git a/packages/pds/src/lexicon/lexicons.ts b/packages/pds/src/lexicon/lexicons.ts index 5ee7cd3d424..f3cbd252cbf 100644 --- a/packages/pds/src/lexicon/lexicons.ts +++ b/packages/pds/src/lexicon/lexicons.ts @@ -8949,15 +8949,8 @@ export const schemaDict = { type: 'array', items: { type: 'string', - knownValues: [ - 'like', - 'repost', - 'follow', - 'mention', - 'reply', - 'quote', - 'starterpack-joined', - ], + description: + 'A reason that matches the reason property of #notification.', }, }, limit: { diff --git a/packages/pds/src/lexicon/types/app/bsky/notification/listNotifications.ts b/packages/pds/src/lexicon/types/app/bsky/notification/listNotifications.ts index 32cd7dcc797..56595f0da7d 100644 --- a/packages/pds/src/lexicon/types/app/bsky/notification/listNotifications.ts +++ b/packages/pds/src/lexicon/types/app/bsky/notification/listNotifications.ts @@ -12,15 +12,7 @@ import * as ComAtprotoLabelDefs from '../../../com/atproto/label/defs' export interface QueryParams { /** Notification types to include in response. */ - filter?: - | 'like' - | 'repost' - | 'follow' - | 'mention' - | 'reply' - | 'quote' - | 'starterpack-joined' - | (string & {})[] + filter?: string[] limit: number priority?: boolean cursor?: string From 78c5a8d76bb2eac707865abca31c36ab91420f41 Mon Sep 17 00:00:00 2001 From: dholms Date: Wed, 11 Dec 2024 13:37:22 -0600 Subject: [PATCH 6/6] filter -> reasons --- .changeset/stupid-feet-allow.md | 2 +- lexicons/app/bsky/notification/listNotifications.json | 4 ++-- packages/api/src/client/lexicons.ts | 4 ++-- .../client/types/app/bsky/notification/listNotifications.ts | 4 ++-- packages/bsky/src/lexicon/lexicons.ts | 4 ++-- .../lexicon/types/app/bsky/notification/listNotifications.ts | 4 ++-- packages/ozone/src/lexicon/lexicons.ts | 4 ++-- .../lexicon/types/app/bsky/notification/listNotifications.ts | 4 ++-- packages/pds/src/lexicon/lexicons.ts | 4 ++-- .../lexicon/types/app/bsky/notification/listNotifications.ts | 4 ++-- 10 files changed, 19 insertions(+), 19 deletions(-) diff --git a/.changeset/stupid-feet-allow.md b/.changeset/stupid-feet-allow.md index d8e892933c1..1aef729861a 100644 --- a/.changeset/stupid-feet-allow.md +++ b/.changeset/stupid-feet-allow.md @@ -5,4 +5,4 @@ "@atproto/pds": patch --- -Add optional filter param to listNotifications +Add optional reasons param to listNotifications diff --git a/lexicons/app/bsky/notification/listNotifications.json b/lexicons/app/bsky/notification/listNotifications.json index 65d35195c7b..7ae3cf9c324 100644 --- a/lexicons/app/bsky/notification/listNotifications.json +++ b/lexicons/app/bsky/notification/listNotifications.json @@ -8,8 +8,8 @@ "parameters": { "type": "params", "properties": { - "filter": { - "description": "Notification types to include in response.", + "reasons": { + "description": "Notification reasons to include in response.", "type": "array", "items": { "type": "string", diff --git a/packages/api/src/client/lexicons.ts b/packages/api/src/client/lexicons.ts index f3cbd252cbf..1e616f1b284 100644 --- a/packages/api/src/client/lexicons.ts +++ b/packages/api/src/client/lexicons.ts @@ -8944,8 +8944,8 @@ export const schemaDict = { parameters: { type: 'params', properties: { - filter: { - description: 'Notification types to include in response.', + reasons: { + description: 'Notification reasons to include in response.', type: 'array', items: { type: 'string', diff --git a/packages/api/src/client/types/app/bsky/notification/listNotifications.ts b/packages/api/src/client/types/app/bsky/notification/listNotifications.ts index dd692a190ed..92b3a27fece 100644 --- a/packages/api/src/client/types/app/bsky/notification/listNotifications.ts +++ b/packages/api/src/client/types/app/bsky/notification/listNotifications.ts @@ -10,8 +10,8 @@ import * as AppBskyActorDefs from '../actor/defs' import * as ComAtprotoLabelDefs from '../../../com/atproto/label/defs' export interface QueryParams { - /** Notification types to include in response. */ - filter?: string[] + /** Notification reasons to include in response. */ + reasons?: string[] limit?: number priority?: boolean cursor?: string diff --git a/packages/bsky/src/lexicon/lexicons.ts b/packages/bsky/src/lexicon/lexicons.ts index 52072d15014..140e617917b 100644 --- a/packages/bsky/src/lexicon/lexicons.ts +++ b/packages/bsky/src/lexicon/lexicons.ts @@ -8944,8 +8944,8 @@ export const schemaDict = { parameters: { type: 'params', properties: { - filter: { - description: 'Notification types to include in response.', + reasons: { + description: 'Notification reasons to include in response.', type: 'array', items: { type: 'string', diff --git a/packages/bsky/src/lexicon/types/app/bsky/notification/listNotifications.ts b/packages/bsky/src/lexicon/types/app/bsky/notification/listNotifications.ts index 56595f0da7d..88fe90a0518 100644 --- a/packages/bsky/src/lexicon/types/app/bsky/notification/listNotifications.ts +++ b/packages/bsky/src/lexicon/types/app/bsky/notification/listNotifications.ts @@ -11,8 +11,8 @@ import * as AppBskyActorDefs from '../actor/defs' import * as ComAtprotoLabelDefs from '../../../com/atproto/label/defs' export interface QueryParams { - /** Notification types to include in response. */ - filter?: string[] + /** Notification reasons to include in response. */ + reasons?: string[] limit: number priority?: boolean cursor?: string diff --git a/packages/ozone/src/lexicon/lexicons.ts b/packages/ozone/src/lexicon/lexicons.ts index f3cbd252cbf..1e616f1b284 100644 --- a/packages/ozone/src/lexicon/lexicons.ts +++ b/packages/ozone/src/lexicon/lexicons.ts @@ -8944,8 +8944,8 @@ export const schemaDict = { parameters: { type: 'params', properties: { - filter: { - description: 'Notification types to include in response.', + reasons: { + description: 'Notification reasons to include in response.', type: 'array', items: { type: 'string', diff --git a/packages/ozone/src/lexicon/types/app/bsky/notification/listNotifications.ts b/packages/ozone/src/lexicon/types/app/bsky/notification/listNotifications.ts index 56595f0da7d..88fe90a0518 100644 --- a/packages/ozone/src/lexicon/types/app/bsky/notification/listNotifications.ts +++ b/packages/ozone/src/lexicon/types/app/bsky/notification/listNotifications.ts @@ -11,8 +11,8 @@ import * as AppBskyActorDefs from '../actor/defs' import * as ComAtprotoLabelDefs from '../../../com/atproto/label/defs' export interface QueryParams { - /** Notification types to include in response. */ - filter?: string[] + /** Notification reasons to include in response. */ + reasons?: string[] limit: number priority?: boolean cursor?: string diff --git a/packages/pds/src/lexicon/lexicons.ts b/packages/pds/src/lexicon/lexicons.ts index f3cbd252cbf..1e616f1b284 100644 --- a/packages/pds/src/lexicon/lexicons.ts +++ b/packages/pds/src/lexicon/lexicons.ts @@ -8944,8 +8944,8 @@ export const schemaDict = { parameters: { type: 'params', properties: { - filter: { - description: 'Notification types to include in response.', + reasons: { + description: 'Notification reasons to include in response.', type: 'array', items: { type: 'string', diff --git a/packages/pds/src/lexicon/types/app/bsky/notification/listNotifications.ts b/packages/pds/src/lexicon/types/app/bsky/notification/listNotifications.ts index 56595f0da7d..88fe90a0518 100644 --- a/packages/pds/src/lexicon/types/app/bsky/notification/listNotifications.ts +++ b/packages/pds/src/lexicon/types/app/bsky/notification/listNotifications.ts @@ -11,8 +11,8 @@ import * as AppBskyActorDefs from '../actor/defs' import * as ComAtprotoLabelDefs from '../../../com/atproto/label/defs' export interface QueryParams { - /** Notification types to include in response. */ - filter?: string[] + /** Notification reasons to include in response. */ + reasons?: string[] limit: number priority?: boolean cursor?: string