Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dispose player implementation #1470

Merged
merged 5 commits into from
Apr 11, 2023
Merged

fix: dispose player implementation #1470

merged 5 commits into from
Apr 11, 2023

Conversation

Gustl22
Copy link
Collaborator

@Gustl22 Gustl22 commented Apr 11, 2023

Description

The implementation to dispose a player on the native side was missing for many platforms.

Checklist

  • The title of my PR starts with a [Conventional Commit] prefix (fix:, feat:, docs:, chore: etc).
  • I have read the [Contributor Guide] and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in [example].

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

See #1467 (comment)

@Gustl22 Gustl22 requested review from spydon and luanpotter April 11, 2023 21:26
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds bad, should we release 4.0.1 with this tomorrow maybe?

@Gustl22
Copy link
Collaborator Author

Gustl22 commented Apr 11, 2023

Yes, completely forgot about the dispose statement, which we didn't have before. So it should work as before after upgrading, but it's better for resources to be able to dispose the player, if not needed anymore.
We did have a dispose method, but not linked to the native players. So it would probably break for some users, if leave unfixed.

@Gustl22 Gustl22 merged commit d9026c1 into main Apr 11, 2023
@Gustl22 Gustl22 deleted the gustl22/method-dispose branch April 11, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants