Cant recreate evm with ContextWithHandlerCfg

[CorrM]

After read this issue: #1062.
I got the concept of recreate evm, but ContextWithHandlerCfg doesnt have clone, so what the proper way to achive multi-threading evm instance.

Also i want db to be shared cross all threads like when i call insert_account_info in thread effect all other threads.

[CorrM]

After some digging

let cfg = ContextWithHandlerCfg::new(self.ctx_with_handler.context.clone(), self.ctx_with_handler.cfg.clone());
Evm::builder().with_context_with_handler_cfg(cfg).build();

Why i can ContextWithHandlerCfg::new(self.ctx_with_handler.context.clone(), self.ctx_with_handler.cfg.clone()) but can't self.ctx_with_handler.clone() ?
Is this correct way to do it, its work but correct way ???

But db state not shared.

[rakita]

You can't as there is no Clone impl on ContextWithHandlerCfg. You are free to make PR that adds it.

Something similar to:

revm/crates/revm/src/context.rs

Lines 26 to 36 in 1411784

	impl<EXT: Clone, DB: Database + Clone> Clone for Context<EXT, DB>
	where
	DB::Error: Clone,
	{
	fn clone(&self) -> Self {
	Self {
	evm: self.evm.clone(),
	external: self.external.clone(),
	}
	}
	}

[CorrM]

You can't as there is no Clone impl on ContextWithHandlerCfg. You are free to make PR that adds it.

Something similar to:

revm/crates/revm/src/context.rs

Lines 26 to 36 in 1411784

	impl<EXT: Clone, DB: Database + Clone> Clone for Context<EXT, DB>
	where
	DB::Error: Clone,
	{
	fn clone(&self) -> Self {
	Self {
	evm: self.evm.clone(),
	external: self.external.clone(),
	}
	}
	}

what about

Also i want db to be shared cross all threads like when i call insert_account_info in thread effect all other threads.

[rakita]

Also i want db to be shared cross all threads like when i call insert_account_info in thread effect all other threads.

This would mean creating a new struct with RwLock around data. Or what people do is use DatabaseRef to share it across the threads as it does not have mut functions. It is up to your use case