-
Notifications
You must be signed in to change notification settings - Fork 42
node-sass binary not found by new nodejs, can't build due to node-gyp py2.7 dep #795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I can't reproduce this. My current setup on Windows is Node.js v14.15, FYI. Are you perhaps using an oldish version of |
This is on Will try upgrading from npm 6 to npm 7 and see, meanwhile.
|
@milindsmart, yes, I can reproduce the error by directly trying to install [email protected]. However, note that [email protected] is an optional dependency for @angular-devkit/build-angular, so it does seem to get skipped over during install and is not causing an issue for me with Node.js v14.15, npm v7.6.3, and GridPath v0.9.0. Please let me know if you're still seeing the problem after upgrading node, npm, and gridpath. |
Updating Would it be possible to indicate/enforce a minimum node/npm version for GridPath?
|
Thanks, @milindsmart. Yes, it makes sense to me to add a brief note on the node and npm version requirements to the README file under the ui folder, probably adding an npm section under the NodeJS section. I can do that as part of the next release (coming soon) and of course you are welcome to pull request something in. (Note that the last time you contributed, your commit didn't seem to be recognized as coming from your GitHub user, probably because of a mismatched email address, so look into this to get the contribution credit on GitHub.) |
Ok confirmed that the GUI built after the npm version upgrade works properly. Since @angular-devkit/build-angular is the one specifying a version of node-sass that's incompatible with later versions of nodejs, is it possible to bump up the version of @angular-devkit/build-angular in package.json from 0.13.0? I'm not yet comfortable enough with the nodejs ecosystem to contribute though... Thanks for the tip on the contribution credit, it was indeed a mismatched email address, fixed now. |
Yes, you could try, but it may create other incompatibility issues. It's a bit of a chore updating dependencies, so reserving some time is usually required for that maintenance work. |
Recently tried to install GP again on a new PC, ran into errors with UI during
npm install
:node-sass 4.12.0
is supported only onnodejs <12
node-sass
isrequired
by@angular-devkit/build-angular
, whose required version 0.13 constrains node-sass from being updated to any higher version. Not sure if its safe to revise the required version inpackage.json
upward.npm install
then falls back to compilingnode-sass 4.12.0
from source, but for this it requiresnode-gyp 3.8.0
which requires python 2.7. Also see this.I think, but am not sure, that the fix is to specify the version of nodejs that GridPath UI is compatible with.
The text was updated successfully, but these errors were encountered: