feat(brew): Automatically install and maintain brew package list (#347) #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiftydinar
requested changes
Oct 16, 2024
| if [[ -n "${INSTALL_PACKAGES}" ]]; then | ||
| echo "install:" > /usr/share/bluebuild/brew/repo-info.yml | ||
| echo "${INSTALL_PACKAGES}" | sed 's/^/ - /' >> /usr/share/bluebuild/brew/repo-info.yml | ||
| echo "The following Brew packages will be installed when the system is live:" |
There was a problem hiding this comment.
Suggested change
| echo "The following Brew packages will be installed when the system is live:" | |
| echo "The following Brew packages will be installed when system is booted:" |
| Description=Setup Brew Packages | ||
| After=brew-setup.service | ||
| Requires=brew-setup.service | ||
| ConditionPathExists=!/var/lib/brew-packages-setup.stamp |
There was a problem hiding this comment.
This condition makes this execute only once.
It should execute every boot, to install packages from updated install list over time. If there are no packages, it will just say Package \$package is already installed.
To make logs more sane in this scenario (when there are no new packages to install),
instead of printing this echo for every package, it should print once: Installed packages are up-to-date with install list, no changes need to be done
fiftydinar
requested changes
Oct 16, 2024
xynydev
reviewed
Oct 16, 2024
Comment on lines
+295
to
+296
| # Write brew-packages-setup script | ||
| cat > /usr/bin/brew-packages-setup <<EOF |
There was a problem hiding this comment.
This should be just a file in the module's directory that is cp'd in place. Having it inline doesn't work with syntax highlighting and shellcheck.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know if you want me to make any changes, to comply with the coding standards of the modules project!
Corresponds to #347
Thanks,
T