You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am having issues when the source or target s3 path contains a '%' character. Specifically, the error I am seeing is:
"TypeError: not enough arguments for format string"
I no longer have the full stack trace, but this is happening when message() is called with a single string argument that contains '%' (that are legitimately part of the source or target file path) and with no additional arguments.
This issue was mentioned in issue #33 from 2016. The comment before that issue was closed correctly indicated that the problem was the use of call sites that "call message(str) instead of message('%s', str)" However there appears to still be calls to message(str) in the latest code. One example is:
I am having issues when the source or target s3 path contains a '%' character. Specifically, the error I am seeing is:
"TypeError: not enough arguments for format string"
I no longer have the full stack trace, but this is happening when message() is called with a single string argument that contains '%' (that are legitimately part of the source or target file path) and with no additional arguments.
This issue was mentioned in issue #33 from 2016. The comment before that issue was closed correctly indicated that the problem was the use of call sites that "call message(str) instead of message('%s', str)" However there appears to still be calls to message(str) in the latest code. One example is:
s4cmd/s4cmd.py
Line 1463 in 7191685
Would you prefer to confirm and fix this throughout the codebase or should I open a PR?
The text was updated successfully, but these errors were encountered: