Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -Wconversion warnings during compilation #87

Open
1 task done
678098 opened this issue Aug 17, 2023 · 1 comment
Open
1 task done

Fix -Wconversion warnings during compilation #87

678098 opened this issue Aug 17, 2023 · 1 comment
Labels
A-Other Area: Other enhancement New feature or request good first issue Good for newcomers

Comments

@678098
Copy link
Collaborator

678098 commented Aug 17, 2023

Is there an existing proposal for this?

  • I have searched the existing proposals

Is your feature request related to a problem?

There are ~2900 -Wconversion warnings during compilation (out of ~3000 warnings in total). All or most of them are unprobable to cause any problems in our runtime.

But there are concerns:

  • Really interesting warnings could be lost in this noise.
  • Logs become larger in general.
  • Prevents from zero-warning compilation.

Info to read:
https://gcc.gnu.org/wiki/NewWconversion

Describe the solution you'd like

Some of these conversion warnings are straightforward to fix. While the scale of 2900 warnings is huge, it might be good to split the work into a smaller chunks: make changes to the simplest cases, on a file or several-files basis, no more than 5-10 changes per PR etc...

Alternatives you considered

Suppress -Wconversion warning during compilation to remove noise - but for me it's better to fix it

Contribution workflow

  1. Go to the Github Actions for this project: https://github.com/bloomberg/blazingmq/actions
  2. Find the nearest main branch build
  3. Open logs for Build BlazingMQ
  4. Ctrl+F -Wconversion to find an intersting place to fix
@678098 678098 added enhancement New feature or request good first issue Good for newcomers labels Aug 17, 2023
@hallfox
Copy link
Collaborator

hallfox commented Aug 17, 2023

Agreed here, most of these are due to small comparison, but there doesn't seem to be good tool for helping with applying fixes for these. Personally I think we might want to start by fixing the -Wconversion warnings in a package of mwc and work our way to bmq, mqb, and bmqbrkr from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Other Area: Other enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants