Skip to content

perf: Avoid repeated MCP queries during streaming responses #6138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlongwell-block merged 1 commit into from
Dec 16, 2025
+3 −4
Merged

perf: Avoid repeated MCP queries during streaming responses #6138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/goose/src/agents/agent.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,11 +289,11 @@ impl Agent {
async fn categorize_tools(
&self,
response: &Message,
_tools: &[rmcp::model::Tool],
tools: &[rmcp::model::Tool],
) -> ToolCategorizeResult {
// Categorize tool requests
let (frontend_requests, remaining_requests, filtered_response) =
self.categorize_tool_requests(response).await;
self.categorize_tool_requests(response, tools).await;

ToolCategorizeResult {
frontend_requests,
Expand Down
3 changes: 1 addition & 2 deletions crates/goose/src/agents/reply_parts.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,9 +270,8 @@ impl Agent {
pub(crate) async fn categorize_tool_requests(
&self,
response: &Message,
tools: &[Tool],
) -> (Vec<ToolRequest>, Vec<ToolRequest>, Message) {
let tools = self.list_tools(None).await;

// First collect all tool requests with coercion applied
let tool_requests: Vec<ToolRequest> = response
.content
Expand Down
Loading