Skip to content

Added transaction commits to multi sql functions in session_manager #5693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DOsinga merged 2 commits into from
Nov 12, 2025
Merged

Added transaction commits to multi sql functions in session_manager #5693

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8f82bc
Added transaction commits to multi sql functions in session_manager
tiensi Nov 12, 2025
3622c97
Removed tests
tiensi Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions crates/goose/src/session/session_manager.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -970,6 +970,8 @@ impl SessionStorage {
}

async fn add_message(&self, session_id: &str, message: &Message) -> Result<()> {
let mut tx = self.pool.begin().await?;

let metadata_json = serde_json::to_string(&message.metadata)?;

sqlx::query(
Expand All @@ -983,14 +985,15 @@ impl SessionStorage {
.bind(serde_json::to_string(&message.content)?)
.bind(message.created)
.bind(metadata_json)
.execute(&self.pool)
.execute(&mut *tx)
.await?;

sqlx::query("UPDATE sessions SET updated_at = datetime('now') WHERE id = ?")
.bind(session_id)
.execute(&self.pool)
.execute(&mut *tx)
.await?;

tx.commit().await?;
Ok(())
}

Expand Down Expand Up @@ -1049,10 +1052,12 @@ impl SessionStorage {
}

async fn delete_session(&self, session_id: &str) -> Result<()> {
let mut tx = self.pool.begin().await?;

let exists =
sqlx::query_scalar::<_, bool>("SELECT EXISTS(SELECT 1 FROM sessions WHERE id = ?)")
.bind(session_id)
.fetch_one(&self.pool)
.fetch_one(&mut *tx)
.await?;

if !exists {
Expand All @@ -1061,14 +1066,15 @@ impl SessionStorage {

sqlx::query("DELETE FROM messages WHERE session_id = ?")
.bind(session_id)
.execute(&self.pool)
.execute(&mut *tx)
.await?;

sqlx::query("DELETE FROM sessions WHERE id = ?")
.bind(session_id)
.execute(&self.pool)
.execute(&mut *tx)
.await?;

tx.commit().await?;
Ok(())
}

Expand Down