Skip to content

Add bottom menu extension selection #5352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zanesq merged 4 commits into from
Oct 24, 2025
Merged

Add bottom menu extension selection #5352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
07abfa3
add bottom menu extension selection for ALPHA
zanesq Oct 24, 2025
4460bf3
Merge branches 'main' and 'zane/next-camp/chat-extension-toggle' of g…
zanesq Oct 24, 2025
37dd326
- Remove unused ExtensionItem component
zanesq Oct 24, 2025
592dce6
- Remove fetchExtensions callback wrapper and unnecessary fetch calls
zanesq Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ui/desktop/src/components/ChatInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import { LocalMessageStorage } from '../utils/localMessageStorage';
import { DirSwitcher } from './bottom_menu/DirSwitcher';
import ModelsBottomBar from './settings/models/bottom_bar/ModelsBottomBar';
import { BottomMenuModeSelection } from './bottom_menu/BottomMenuModeSelection';
import { BottomMenuExtensionSelection } from './bottom_menu/BottomMenuExtensionSelection';
import { AlertType, useAlerts } from './alerts';
import { useConfig } from './ConfigContext';
import { useModelAndProvider } from './ModelAndProviderContext';
Expand Down Expand Up @@ -1590,7 +1591,12 @@ export default function ChatInput({
</Tooltip>
<div className="w-px h-4 bg-border-default mx-2" />
<BottomMenuModeSelection />
<div className="w-px h-4 bg-border-default mx-2" />
{process.env.ALPHA && sessionId && (
<>
<div className="w-px h-4 bg-border-default mx-2" />
<BottomMenuExtensionSelection sessionId={sessionId} />
</>
)}
<div className="flex items-center h-full">
<Tooltip>
<TooltipTrigger asChild>
Expand Down
147 changes: 147 additions & 0 deletions ui/desktop/src/components/bottom_menu/BottomMenuExtensionSelection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,147 @@
import { useCallback, useMemo, useState } from 'react';
import { Puzzle } from 'lucide-react';
import { DropdownMenu, DropdownMenuContent, DropdownMenuTrigger } from '../ui/dropdown-menu';
import { Input } from '../ui/input';
import { Switch } from '../ui/switch';
import { FixedExtensionEntry, useConfig } from '../ConfigContext';
import { toggleExtension } from '../settings/extensions/extension-manager';
import { toastService } from '../../toasts';
import { getFriendlyTitle } from '../settings/extensions/subcomponents/ExtensionList';

interface BottomMenuExtensionSelectionProps {
sessionId: string;
}

export const BottomMenuExtensionSelection = ({ sessionId }: BottomMenuExtensionSelectionProps) => {
const [searchQuery, setSearchQuery] = useState('');
const [isOpen, setIsOpen] = useState(false);
const { extensionsList, addExtension } = useConfig();

const handleToggle = useCallback(
async (extensionConfig: FixedExtensionEntry) => {
if (!sessionId) {
toastService.error({
title: 'Extension Toggle Error',
msg: 'No active session found. Please start a chat session first.',
traceback: 'No session ID available',
});
return;
}

try {
const toggleDirection = extensionConfig.enabled ? 'toggleOff' : 'toggleOn';

await toggleExtension({
toggle: toggleDirection,
extensionConfig: extensionConfig,
addToConfig: addExtension,
toastOptions: { silent: false },
sessionId: sessionId,
});
} catch (error) {
toastService.error({
title: 'Extension Error',
msg: `Failed to ${extensionConfig.enabled ? 'disable' : 'enable'} ${extensionConfig.name}`,
traceback: error instanceof Error ? error.message : String(error),
});
}
},
[sessionId, addExtension]
);

const filteredExtensions = useMemo(() => {
return extensionsList.filter((ext) => {
const query = searchQuery.toLowerCase();
return (
ext.name.toLowerCase().includes(query) ||
(ext.description && ext.description.toLowerCase().includes(query))
);
});
}, [extensionsList, searchQuery]);

const sortedExtensions = useMemo(() => {
const getTypePriority = (type: string): number => {
const priorities: Record<string, number> = {
builtin: 0,
platform: 1,
frontend: 2,
};
return priorities[type] ?? Number.MAX_SAFE_INTEGER;
};

return [...filteredExtensions].sort((a, b) => {
// First sort by priority type
const typeDiff = getTypePriority(a.type) - getTypePriority(b.type);
if (typeDiff !== 0) return typeDiff;

// Then sort by enabled status (enabled first)
if (a.enabled !== b.enabled) return a.enabled ? -1 : 1;

// Finally sort alphabetically
return a.name.localeCompare(b.name);
});
}, [filteredExtensions]);
Copy link
Collaborator

@DOsinga DOsinga Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we seem to have two sorts going on here. let's combine them into one. also the first sort looks at bundled which I don't think really gives us anything. if we wanted to do this, prioritize anything that is of type {Builtin, Platform, Frontend} I would say


const activeCount = useMemo(() => {
return extensionsList.filter((ext) => ext.enabled).length;
}, [extensionsList]);

return (
<DropdownMenu
open={isOpen}
onOpenChange={(open) => {
setIsOpen(open);
if (!open) {
setSearchQuery(''); // Reset search when closing
}
}}
>
<DropdownMenuTrigger asChild>
<button
className="flex items-center cursor-pointer [&_svg]:size-4 text-text-default/70 hover:text-text-default hover:scale-100 hover:bg-transparent text-xs"
title="manage extensions"
>
<Puzzle className="mr-1 h-4 w-4" />
<span>{activeCount}</span>
</button>
</DropdownMenuTrigger>
<DropdownMenuContent side="top" align="center" className="w-64">
<div className="p-2">
<Input
type="text"
placeholder="search extensions..."
value={searchQuery}
onChange={(e) => setSearchQuery(e.target.value)}
className="h-8 text-sm"
autoFocus
/>
</div>
<div className="max-h-[400px] overflow-y-auto">
{sortedExtensions.length === 0 ? (
<div className="px-2 py-4 text-center text-sm text-text-default/70">
{searchQuery ? 'no extensions found' : 'no extensions available'}
</div>
) : (
sortedExtensions.map((ext) => (
<div
key={ext.name}
className="flex items-center justify-between px-2 py-2 hover:bg-background-hover cursor-pointer"
onClick={() => handleToggle(ext)}
title={ext.description || ext.name}
>
<div className="text-sm font-medium text-text-default">{getFriendlyTitle(ext)}</div>
<div onClick={(e) => e.stopPropagation()}>
<Switch
checked={ext.enabled}
onCheckedChange={() => handleToggle(ext)}
variant="mono"
/>
</div>
</div>
))
)}
</div>
</DropdownMenuContent>
</DropdownMenu>
);
};
Loading