Skip to content

hotfix: fix build #3102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelneale merged 6 commits into from
Jun 27, 2025
Merged

hotfix: fix build #3102

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9de2cfd
keep clippy happy
michaelneale Jun 27, 2025
d3a452b
missed these
michaelneale Jun 27, 2025
94438e1
another one
michaelneale Jun 27, 2025
cfa5796
cargo fmt
michaelneale Jun 27, 2025
eacee76
clippy config
michaelneale Jun 27, 2025
1d5f08e
try this approach
michaelneale Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions crates/goose/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ async fn main() -> Result<(), Box<dyn Error>> {
// Create base directory
fs::create_dir_all(BASE_DIR)?;
println!("cargo:rerun-if-changed=build.rs");
println!("cargo:rerun-if-changed={}", BASE_DIR);
println!("cargo:rerun-if-changed={BASE_DIR}");

for tokenizer_name in TOKENIZERS {
download_tokenizer(tokenizer_name).await?;
Expand All @@ -33,18 +33,17 @@ async fn download_tokenizer(repo_id: &str) -> Result<(), Box<dyn Error>> {

// Check if file already exists
if Path::new(&file_path).exists() {
println!("Tokenizer for {} already exists, skipping...", repo_id);
println!("Tokenizer for {repo_id} already exists, skipping...");
return Ok(());
}

println!("Downloading tokenizer for {}...", repo_id);
println!("Downloading tokenizer for {repo_id}...");

// Download the file
let response = reqwest::get(&file_url).await?;
if !response.status().is_success() {
return Err(format!(
"Failed to download tokenizer for {}, status: {}",
repo_id,
"Failed to download tokenizer for {repo_id}, status: {}",
response.status()
)
.into());
Expand All @@ -53,6 +52,6 @@ async fn download_tokenizer(repo_id: &str) -> Result<(), Box<dyn Error>> {
let content = response.bytes().await?;
fs::write(&file_path, content)?;

println!("Downloaded {} to {}", repo_id, file_path);
println!("Downloaded {repo_id} to {file_path}");
Ok(())
}
Loading