Skip to content

feat: allow list of MCPs #1821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
michaelneale wants to merge 10 commits into from
Closed

feat: allow list of MCPs #1821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1819799
first pass
michaelneale Mar 24, 2025
18dc619
simplifying
michaelneale Mar 24, 2025
851bd17
tidying up and moving to different place
michaelneale Mar 24, 2025
75ae20c
progress
michaelneale Mar 24, 2025
2a0f8d4
format was wrong, and had a weakness in command path
michaelneale Mar 24, 2025
b716412
download from URL now
michaelneale Mar 24, 2025
1a51228
falling back to cached download
michaelneale Mar 24, 2025
c17115a
cleaning up
michaelneale Mar 24, 2025
136ca7d
tidy up
michaelneale Mar 24, 2025
a241de7
tidy up fmt
michaelneale Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
127 changes: 109 additions & 18 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion crates/goose/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ reqwest = { version = "0.12.9", features = [
"zstd",
"charset",
"http2",
"stream"
"stream",
"blocking"
], default-features = false }
tokio = { version = "1.0", features = ["full"] }
serde = { version = "1.0", features = ["derive"] }
Expand Down Expand Up @@ -82,6 +83,7 @@ tempfile = "3.15.0"
serial_test = "3.2.0"
mockall = "0.13.1"
wiremock = "0.6.0"
mockito = "1.4.0"
tokio = { version = "1.0", features = ["full"] }

[[example]]
Expand Down
3 changes: 3 additions & 0 deletions crates/goose/src/agents/capabilities.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,9 @@ impl Capabilities {
/// Add a new MCP extension based on the provided client type
// TODO IMPORTANT need to ensure this times out if the extension command is broken!
pub async fn add_extension(&mut self, config: ExtensionConfig) -> ExtensionResult<()> {
// Validate the command before creating the transport
config.validate_command().map_err(|e| *e)?;

let mut client: Box<dyn McpClientTrait> = match &config {
ExtensionConfig::Sse {
uri, envs, timeout, ..
Expand Down
Loading
Loading