Skip to content

fix: remove other category in settings #1641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yingjiehe-xyz merged 3 commits into from
Mar 12, 2025
Merged

fix: remove other category in settings #1641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7edc34f
fix: remove other category in settings
baxen Mar 12, 2025
1f674b4
Merge branch 'main' into baxen/settings-other
lily-de Mar 12, 2025
9cf33f6
remove duplicate
yingjiehe-xyz Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ui/desktop/src/components/settings/SettingsView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,14 +244,14 @@ export default function SettingsView({
</div>
</section>

<section id="others">
<section id="mode">
<div className="flex justify-between items-center mb-6 border-b border-borderSubtle px-8">
<h2 className="text-xl font-semibold text-textStandard">Others</h2>
<h2 className="text-xl font-semibold text-textStandard">Mode Selection</h2>
</div>

<div className="px-8">
<p className="text-sm text-textStandard mb-4">
Others setting like Goose Mode, Tool Output, Experiment and more
Configure how Goose interacts with tools and extensions
</p>

<ModeSelection />
Expand Down
6 changes: 0 additions & 6 deletions ui/desktop/src/components/settings/basic/ModeSelection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,6 @@ export const ModeSelection = () => {

return (
<div>
<h4 className="font-medium mb-2 text-textStandard">Mode Selection</h4>
<p className="text-sm text-gray-500 dark:text-gray-400 mb-4">
Change the access goose is given to modify, edit or delet files. This setting can be changed
at anytime.
</p>

<div>
{filterGooseModes(currentMode, all_goose_modes, previousApproveModel).map((mode) => (
<ModeSelectionItem
Expand Down
Loading