diff --git a/desktop/src/features/messages/ui/MessageComposer.tsx b/desktop/src/features/messages/ui/MessageComposer.tsx index 05e568f1744..e77e2e0d553 100644 --- a/desktop/src/features/messages/ui/MessageComposer.tsx +++ b/desktop/src/features/messages/ui/MessageComposer.tsx @@ -341,7 +341,6 @@ function MessageComposerImpl({ drafts, emojiAutocomplete, mentions, - onAddressedAgentsSendStarted: addressPulse.pulseMany, onAddressedAgentsComposerCleared: (pubkeys) => restoreAddressedAgentMentionsRef.current(pubkeys), onAddressedAgentsSendFailed: addressPulse.shakeMany, diff --git a/desktop/src/features/messages/ui/useMentionSendFlow.ts b/desktop/src/features/messages/ui/useMentionSendFlow.ts index 10ca0332728..0a4d89c0495 100644 --- a/desktop/src/features/messages/ui/useMentionSendFlow.ts +++ b/desktop/src/features/messages/ui/useMentionSendFlow.ts @@ -52,7 +52,6 @@ export function useMentionSendFlow({ emojiAutocomplete, mentions, onPrepareSendChannel, - onAddressedAgentsSendStarted, onAddressedAgentsComposerCleared, onAddressedAgentsSendFailed, onAddressedAgentsSendSucceeded, @@ -404,9 +403,6 @@ export function useMentionSendFlow({ draft.capturedChannelId === channelIdRef.current || channelIdRef.current === null ) { - if (draft.addressedAgentPubkeys.length > 0) { - onAddressedAgentsSendStarted?.(draft.addressedAgentPubkeys); - } clearComposer(); if (draft.addressedAgentPubkeys.length > 0) { optimisticComposerContent = @@ -640,7 +636,6 @@ export function useMentionSendFlow({ getManagedAgentsByPubkey, mentions.isAgentPubkey, mentions.revalidateMentionPubkeys, - onAddressedAgentsSendStarted, onAddressedAgentsComposerCleared, onAddressedAgentsSendFailed, onAddressedAgentsSendSucceeded, diff --git a/desktop/src/features/messages/ui/useMentionSendFlow.types.ts b/desktop/src/features/messages/ui/useMentionSendFlow.types.ts index 496a73a94a7..fe16ba2f63a 100644 --- a/desktop/src/features/messages/ui/useMentionSendFlow.types.ts +++ b/desktop/src/features/messages/ui/useMentionSendFlow.types.ts @@ -19,7 +19,6 @@ export type UseMentionSendFlowOptions = { emojiAutocomplete: Pick; mentions: UseMentionsResult; onPrepareSendChannel?: (pubkeys?: string[]) => Promise; - onAddressedAgentsSendStarted?: (pubkeys: readonly string[]) => void; onAddressedAgentsComposerCleared?: (pubkeys: readonly string[]) => string; onAddressedAgentsSendFailed?: (pubkeys: readonly string[]) => void; onAddressedAgentsSendSucceeded?: ( diff --git a/desktop/tests/e2e/persistent-agent-audience.spec.ts b/desktop/tests/e2e/persistent-agent-audience.spec.ts index 12a6f07819f..0b957992e2b 100644 --- a/desktop/tests/e2e/persistent-agent-audience.spec.ts +++ b/desktop/tests/e2e/persistent-agent-audience.spec.ts @@ -500,7 +500,7 @@ test("the mention button opens settings and can undo an address", async ({ ).toHaveCount(0); }); -test("always-mentioned agents remain in the mention button while Enter-send resolves", async ({ +test("always-mentioned agents remain selected without replaying their animation while Enter-send resolves", async ({ page, }) => { await installAudienceFixtures(page, { @@ -549,7 +549,7 @@ test("always-mentioned agents remain in the mention button while Enter-send reso .not.toContain(""); await expect(avatar).toHaveAttribute( "data-pulse-version", - String(initialPulseVersion + 1), + String(initialPulseVersion), { timeout: 500 }, ); await expect( @@ -587,7 +587,7 @@ test("always-mentioned agents remain in the mention button while Enter-send reso ).toHaveCount(1); }); -test("a failed always-mentioned send shakes the composer avatar", async ({ +test("a failed always-mentioned send shakes the composer avatar without replaying its selection animation", async ({ page, }) => { await installAudienceFixtures(page, { @@ -610,7 +610,7 @@ test("a failed always-mentioned send shakes the composer avatar", async ({ await expect(avatar).toHaveAttribute( "data-pulse-version", - String(initialPulseVersion + 1), + String(initialPulseVersion), { timeout: 500 }, ); await expect(input).toHaveText("@Morgarita please retry");