From 5e4ff4975148ec30777d6c882c522b7fa0fe6d98 Mon Sep 17 00:00:00 2001
From: Wes <wesbillman@users.noreply.github.com>
Date: Wed, 15 Jul 2026 09:54:01 -0600
Subject: [PATCH] fix(desktop): filter punctuation from avatar initials

Co-authored-by: Pinky <44b8e82baa6e0e254e0208d68f335c283c94e7b78dd1fa10d5a49d3f13dd0435@sprout-oss.stage.blox.sqprod.co>
Signed-off-by: Wes <wesbillman@users.noreply.github.com>
---
 .../ui/CommunityIconSettingsCard.tsx          |  6 ++---
 .../sidebar/ui/CommunityRail.test.mjs         | 20 +----------------
 .../src/features/sidebar/ui/CommunityRail.tsx |  8 +------
 desktop/src/shared/lib/initials.test.mjs      | 22 +++++++++++++++++++
 desktop/src/shared/lib/initials.ts            |  1 +
 5 files changed, 27 insertions(+), 30 deletions(-)
 create mode 100644 desktop/src/shared/lib/initials.test.mjs

diff --git a/desktop/src/features/communities/ui/CommunityIconSettingsCard.tsx b/desktop/src/features/communities/ui/CommunityIconSettingsCard.tsx
index bf62c253e4d..4f557fd8a3e 100644
--- a/desktop/src/features/communities/ui/CommunityIconSettingsCard.tsx
+++ b/desktop/src/features/communities/ui/CommunityIconSettingsCard.tsx
@@ -9,7 +9,7 @@ import {
   communityIconQueryKey,
 } from "@/features/communities/useCommunityIcons";
 import { useCommunities } from "@/features/communities/useCommunities";
-import { communityInitials } from "@/features/sidebar/ui/CommunityRail";
+import { getInitials } from "@/shared/lib/initials";
 import { setCommunityIcon } from "@/shared/api/communityProfile";
 import { Button } from "@/shared/ui/button";
 
@@ -72,9 +72,7 @@ export function CommunityIconSettingsCard() {
   }
 
   const icon = iconQuery.data ?? null;
-  const initials = activeCommunity
-    ? communityInitials(activeCommunity.name)
-    : "";
+  const initials = activeCommunity ? getInitials(activeCommunity.name) : "";
 
   return (
     <div className="space-y-1.5" data-testid="community-icon-settings">
diff --git a/desktop/src/features/sidebar/ui/CommunityRail.test.mjs b/desktop/src/features/sidebar/ui/CommunityRail.test.mjs
index b2094b18bc0..8a8b33b15f9 100644
--- a/desktop/src/features/sidebar/ui/CommunityRail.test.mjs
+++ b/desktop/src/features/sidebar/ui/CommunityRail.test.mjs
@@ -1,25 +1,7 @@
 import assert from "node:assert/strict";
 import { describe, it } from "node:test";
 
-import {
-  communityInitials,
-  communityRailIndicators,
-} from "./CommunityRail.tsx";
-
-describe("communityInitials", () => {
-  it("filters punctuation before deriving initials", () => {
-    assert.equal(communityInitials("B (relay)"), "BR");
-  });
-  it("handles a leading symbol on a single word", () => {
-    assert.equal(communityInitials("(staging)"), "S");
-  });
-  it("still returns plain initials for normal names", () => {
-    assert.equal(communityInitials("Bravo Beta"), "BB");
-  });
-  it("returns empty for a symbol-only name (caller falls back)", () => {
-    assert.equal(communityInitials("()"), "");
-  });
-});
+import { communityRailIndicators } from "./CommunityRail.tsx";
 
 describe("communityRailIndicators", () => {
   it("shows no badge for an observed community with unread but no mentions", () => {
diff --git a/desktop/src/features/sidebar/ui/CommunityRail.tsx b/desktop/src/features/sidebar/ui/CommunityRail.tsx
index 76560d2dc8e..f54de4dd3b7 100644
--- a/desktop/src/features/sidebar/ui/CommunityRail.tsx
+++ b/desktop/src/features/sidebar/ui/CommunityRail.tsx
@@ -36,12 +36,6 @@ type CommunityRailProps = {
 
 const MAX_BADGE = 99;
 
-// Strip punctuation before initials so "B (relay)" yields "BR", not "B(".
-export function communityInitials(name: string): string {
-  const cleaned = name.replace(/[^\p{L}\p{N}\s]/gu, " ");
-  return getInitials(cleaned);
-}
-
 /**
  * Presentation decisions for one community button, derived from its observed
  * mention state. Pure so it can be unit-tested without a DOM. The `state` guard
@@ -129,7 +123,7 @@ function CommunityButton({
                     src={iconUrl}
                   />
                 ) : (
-                  communityInitials(community.name) || "🐝"
+                  getInitials(community.name) || "🐝"
                 )}
               </span>
               {showBadge ? (
diff --git a/desktop/src/shared/lib/initials.test.mjs b/desktop/src/shared/lib/initials.test.mjs
new file mode 100644
index 00000000000..19e9f8dbcc8
--- /dev/null
+++ b/desktop/src/shared/lib/initials.test.mjs
@@ -0,0 +1,22 @@
+import assert from "node:assert/strict";
+import { describe, it } from "node:test";
+
+import { getInitials } from "./initials.ts";
+
+describe("getInitials", () => {
+  it("filters punctuation before deriving initials", () => {
+    assert.equal(getInitials("B (relay)"), "BR");
+  });
+
+  it("handles a leading symbol on a single word", () => {
+    assert.equal(getInitials("(staging)"), "S");
+  });
+
+  it("still returns plain initials for normal names", () => {
+    assert.equal(getInitials("Bravo Beta"), "BB");
+  });
+
+  it("returns empty for a symbol-only name", () => {
+    assert.equal(getInitials("()"), "");
+  });
+});
diff --git a/desktop/src/shared/lib/initials.ts b/desktop/src/shared/lib/initials.ts
index 8068c1959c3..23dbf2ff93b 100644
--- a/desktop/src/shared/lib/initials.ts
+++ b/desktop/src/shared/lib/initials.ts
@@ -1,6 +1,7 @@
 /** Derive up to two uppercase initials from a display name. */
 export function getInitials(name: string): string {
   return name
+    .replace(/[^\p{L}\p{N}\s]/gu, " ")
     .trim()
     .split(/\s+/)
     .map((part) => part[0] ?? "")