feat: add IsAvailableChanged event to Gw2MumbleService #965
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
IsAvailableChanged
event to theGw2MumbleService
. Implemented the same way the other mumble events are implemented.This is useful for handling the (un)availability of the
Gw2MumbleService
. With this change, a module can listen to the event instead of regularly checkingGw2MumbleService.IsAvailable
.Remark: When subscribing to the event, the user still has to check
Gw2MumbleService.IsAvailable
once, because the event only fires when the value changes, regardless of it's value at the time of subscription.Discussion Reference
All new features must be discussed prior to code review. This is to ensure that the implementation aligns with other design considerations. Please link to the Discord discussion:
https://discord.com/channels/531175899588984842/536970543736291346/1235308611706687529
Is this a breaking change?
Breaking changes require additional review prior to merging. If you answer yes, please explain what breaking changes have been made.
No