Merge pull request #1086 from blacklanternsecurity/dns-dedup-bugfix

Don't deduplicate DNS child events

Author: TheTechromancer

bbot/core/helpers/dns.py

@@ -334,6 +334,10 @@ async def _resolve_hostname(self, query, **kwargs):
 
         if results:
             self._last_dns_success = time.time()
+            self.debug(f"Answers for {query} with kwargs={kwargs}: {list(results)}")
+
+        if errors:
+            self.debug(f"Errors for {query} with kwargs={kwargs}: {errors}")
 
         return results, errors
 
@@ -1038,6 +1042,7 @@ def _get_dummy_module(self, name):
             dummy_module = self._dummy_modules[name]
         except KeyError:
             dummy_module = self.parent_helper._make_dummy_module(name=name, _type="DNS")
+            dummy_module.suppress_dupes = False
             self._dummy_modules[name] = dummy_module
         return dummy_module
 

bbot/scanner/manager.py

@@ -319,6 +319,7 @@ async def _emit_event(self, event, **kwargs):
                                         f'Event validation failed for DNS child of {source_event}: "{record}" ({rdtype}): {e}'
                                     )
                     for child_event in dns_child_events:
+                        log.debug(f"Queueing DNS child for {event}: {child_event}")
                         self.queue_event(child_event)
 
         except ValidationError as e: