Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty Space prefix to section name if no icon provided #104

Closed
Sairam90 opened this issue Aug 8, 2024 · 5 comments
Closed

Empty Space prefix to section name if no icon provided #104

Sairam90 opened this issue Aug 8, 2024 · 5 comments

Comments

@Sairam90
Copy link
Contributor

Sairam90 commented Aug 8, 2024

The section names get prefixed by an extra space where icon value is empty - due to this part of the code which is not intended I guess

nav.txt
sample_sections.txt

@Sairam90
Copy link
Contributor Author

Sairam90 commented Aug 8, 2024

If this is verified I could add a fix - Could you add me as a contributor ?

@blackary
Copy link
Owner

blackary commented Aug 8, 2024

Great catch! Feel free to make a pull request with a fix!

@Sairam90
Copy link
Contributor Author

Sairam90 commented Aug 8, 2024

Am unable to push my local feature branch to the repo
Permission to blackary/st_pages.git denied
Is it something on my side ?

Also , are any of the tests relevant in this case ? - I am unable to find the fixture "page" when I tried some of them . Could you help with running the tests in case I am missing something there ?

@blackary
Copy link
Owner

blackary commented Aug 8, 2024

You'll need to create a fork of the repo and create a PR from that fork.

You should be able to run the whole suite of tests by just running tox, but you can also just let them run automatically on github when you create the PR

@blackary
Copy link
Owner

blackary commented Aug 8, 2024

Closed by #105

@blackary blackary closed this as completed Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants