From 33acb579ab28579d6dcc78964eac966a07a9ef56 Mon Sep 17 00:00:00 2001 From: Stefan Becker Date: Wed, 29 Nov 2023 10:04:55 +0200 Subject: [PATCH 1/2] build: explicitly require Threads package In some build environments, like Debian Bullseye, the dependency on pthreads is not detected automatically, causing link errors. Explicitly require Threads package and link against Threads::Threads. --- CMakeLists.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index abbfc2b..93d0afe 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -15,6 +15,7 @@ if(CMAKE_BUILD_TYPE STREQUAL Debug) find_package(Qt${QT_VERSION_MAJOR} REQUIRED COMPONENTS Test) endif() find_package(OpenSSL REQUIRED) +find_package(Threads REQUIRED) # exposes ${TS_FILES} add_subdirectory(data/translations) @@ -79,6 +80,7 @@ target_link_libraries(${TARGET} PRIVATE Qt::Gui Qt::Widgets OpenSSL::Crypto + Threads::Threads ) target_include_directories(${TARGET} PRIVATE ${OPENSSL_INCLUDE_DIR}) From 40c21edcc23262d63f822b17e5e4eaae8185b0e7 Mon Sep 17 00:00:00 2001 From: Stefan Becker Date: Wed, 29 Nov 2023 10:07:28 +0200 Subject: [PATCH 2/2] build: add Debian oldstable to CI We need to exclude Qt6 variant, because it is not available on Debian Bullseye. --- .github/workflows/build-linux.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/build-linux.yml b/.github/workflows/build-linux.yml index 1d7b8ec..d11e939 100644 --- a/.github/workflows/build-linux.yml +++ b/.github/workflows/build-linux.yml @@ -12,6 +12,7 @@ jobs: strategy: matrix: container: + - debian:oldstable - debian:stable - debian:testing - fedora:38 @@ -33,6 +34,11 @@ jobs: - container: fedora:rawhide no_x11: true + exclude: + # Debian Bullseye doesn't have Qt6 + - container: debian:oldstable + qt: 6 + fail-fast: false container: