From cf7756442f94a94bbb0b559ae8eb9b97031d8d13 Mon Sep 17 00:00:00 2001 From: Brian Koropoff Date: Sat, 1 Nov 2014 20:15:48 -0700 Subject: [PATCH] Always consider static methods object-safe This also fixes #18490 as a side-effect by avoiding a later out-of-bounds slice. --- src/librustc/middle/typeck/check/vtable.rs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/librustc/middle/typeck/check/vtable.rs b/src/librustc/middle/typeck/check/vtable.rs index a17194f008565..87b0aed4ac49c 100644 --- a/src/librustc/middle/typeck/check/vtable.rs +++ b/src/librustc/middle/typeck/check/vtable.rs @@ -187,7 +187,11 @@ pub fn check_object_safety(tcx: &ty::ctxt, object_trait: &ty::TyTrait, span: Spa receiver through a trait object", method_name)) } - ty::StaticExplicitSelfCategory | + ty::StaticExplicitSelfCategory => { + // Static methods are always object-safe since they + // can't be called through a trait object + return msgs + } ty::ByReferenceExplicitSelfCategory(..) | ty::ByBoxExplicitSelfCategory => {} }