[AHM Gov] AssetHub as Superuser on Polkadot relay - utils & config #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkontur
reviewed
Apr 8, 2025
relay/common/src/lib.rs
Outdated
| pub struct LocationAsSuperuser<SuperuserLocation, RuntimeOrigin>( | ||
| PhantomData<(SuperuserLocation, RuntimeOrigin)>, | ||
| ); | ||
| impl<SuperuserLocation: Get<Location>, RuntimeOrigin: OriginTrait> ConvertOrigin<RuntimeOrigin> |
Owner
There was a problem hiding this comment.
for matching we use Contains
Suggested change
| impl<SuperuserLocation: Get<Location>, RuntimeOrigin: OriginTrait> ConvertOrigin<RuntimeOrigin> | |
| impl<SuperuserLocation: Contains<Location>, RuntimeOrigin: OriginTrait> ConvertOrigin<RuntimeOrigin> |
bkontur
reviewed
Apr 10, 2025
| use xcm::latest::{Location, OriginKind}; | ||
| use xcm_executor::traits::ConvertOrigin; | ||
|
|
||
| pub struct LocationAsSuperuser<SuperuserLocation, RuntimeOrigin>( |
Owner
There was a problem hiding this comment.
please add here some docs, because it is a pub struct and all pub stuff should have rustdocs
bkontur
reviewed
Apr 10, 2025
bkontur
reviewed
Apr 10, 2025
bkontur
approved these changes
Apr 10, 2025
bkontur
merged commit 306c2ff
into
bkontur:bko-ahm-governance-root
9 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LocalOriginConverter