Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce passing in PKCE and nonce to authenticate client? #1077

Open
Zysberg opened this issue Nov 24, 2024 · 2 comments
Open

Introduce passing in PKCE and nonce to authenticate client? #1077

Zysberg opened this issue Nov 24, 2024 · 2 comments

Comments

@Zysberg
Copy link

Zysberg commented Nov 24, 2024

Using PKCE with a nonce is more secure and highly recommended.
Unless I just poorly misunderstand the codebase, there's no way to generate PKCE code challenge/exchange and nonces to verify the client.

@Zysberg
Copy link
Author

Zysberg commented Dec 5, 2024

If my comment above is not detailed enough, please let me know

@simenandre
Copy link
Member

Thanks for opening the issue.

This seems like a good addition to oidc-react. Feel free to open a PR if you want. I would likely see if there is some hook or feature in oidc-client-ts as well. Contributions from you are what keep our project alive!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants