feat: update policy loading to reflect Oso 0.20.1 changes #259
Conversation
| } | ||
|
|
||
| if (this.options.loadStr) { | ||
| await this.loadStr(this.options.loadStr); | ||
| } | ||
| } | ||
|
|
||
| private async loadFiles(patterns: string[]): Promise<void> { | ||
| private async _loadFiles(patterns: string[]): Promise<void> { |
There was a problem hiding this comment.
Why are you adding an underscore here?
There was a problem hiding this comment.
The loadFiles method is from Polar's Polar.loadFiles, but does not load path wildcards, from what I understood. The _loadFiles without the underscore uses fast-glob to provide solution to this, but can be also renamed. Am I correct or missing something?
Codecov Report
@@ Coverage Diff @@
## main #259 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 40 43 +3
Branches 4 5 +1
=========================================
+ Hits 40 43 +3
Continue to review full report at Codecov.
|
Co-authored-by: Simen A. W. Olsen <[email protected]>
An attempt to resolve #258.
A few comments, mostly due to my lack of experience:
loadFileoption in for backwards compatibility, however do not have any experience with typedoc so the proposed reference is not provided[email protected]or higherloadFileandloadFilesoptionsfast-globdependency, because was unsure how path wildcards can be used in OsoPlease suggest changes/improvements or directly implement edits. Thank you!