Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a isGlobal option #23

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Conversation

youngjoon-lee
Copy link
Contributor

Closes #22

Hi @cobraz , I've tried to import OsoModule as a global module, and I finally found this solution inspired by @nestjs/config.

Please take a look when you have time.

@youngjoon-lee youngjoon-lee changed the title Add a isGlobal option feat: Add a isGlobal option Dec 17, 2020
@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #23 (3fdb7ca) into main (a206c85) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #23   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           33        33           
  Branches         3         3           
=========================================
  Hits            33        33           
Impacted Files Coverage Δ
src/oso.module.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a206c85...3fdb7ca. Read the comment docs.

@simenandre
Copy link
Member

Thank you very much! 🎉

@simenandre simenandre merged commit 479c4c9 into bjerkio:main Dec 18, 2020
github-actions bot pushed a commit that referenced this pull request Dec 18, 2020
# [1.1.0](v1.0.1...v1.1.0) (2020-12-18)

### Features

* Add a isGlobal option ([#23](#23)) ([479c4c9](479c4c9))
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OsoService cannot be resolved in inner modules
2 participants