iOS 16 (am not sure) restoring purchases hangs? #682

sabiland · 2022-09-13T15:18:43Z

Restoring purchases hangs

I am not sure if this is AppStore issue, but today I cannot successfully call restoring purchases method. Completion handler is never called - hangs.
Anyone else with this issue?

My third app still built with Xcode 13 is ok. Both my other apps built with Xcode 14 have the same issues - hangs. I guess the problem could not be with Bitcode setting No (it is not recommended anymore having Bitcode Yes on Pods)?

EDIT: More specifically, this one hangs restoreCompletedTransactions

The text was updated successfully, but these errors were encountered:

Reiszecke · 2022-09-15T19:44:05Z

Yes, there seems to be an issue with iOS 16 https://developer.apple.com/forums/thread/713533

Now I'm not sure if that's a bug on their side that they are going to fix or if some parameters have changed, leading to SwiftyStoreKit not recognizing the data the App Store sends

CH3COOH · 2022-09-15T23:04:15Z

I have tried the SwiftyStoreKit demo app with Xcode 14.1 Beta 1, but the callback is not called after restoring.

Does this problem occur only in the Sandbox environment?

sabiland · 2022-09-16T04:02:51Z

FYI, it’s also in Production environment.
As recommended, I have refactored first of my apps to StoreKit2 with the help of Mercato git library.

mercadodiego · 2022-09-16T18:13:46Z

I can confirm that happens, not on all the devices.

ArthurAlvarez · 2022-09-17T12:45:03Z

I have apps that rely on SwiftyStoreKit and running directly on device and also through Testflight I can purchase and restore with no problems (testing on iPhone 11 Pro, iOS 16.0).

Could you please share more details about your test environment?

sabiland · 2022-09-17T13:07:59Z

After I built my apps (no changes in the code) with Xcode Version 14.0 (14A309), pushed them to AppStore, restore purchases stoped working. I have iPhone 13 Pro (tested it directly on it)

ArthurAlvarez · 2022-09-17T13:08:42Z

After I built my apps (no changes in the code) with Xcode Version 14.0 (14A309), pushed them to AppStore, restore purchases stoped working.

Does it work on Testflight?

Reiszecke · 2022-09-17T13:09:11Z

It's not the Xcode version, my builds are not submitted with Xcode 14

sabiland · 2022-09-17T13:09:27Z

Does it work on Testflight?

Nope. (TestFlight == production right?)

(as suggested on main repo site - I migrated to StoreKit 2 all of my apps)

ArthurAlvarez · 2022-09-17T13:11:29Z

Which version of SwiftyStoreKit are you using?

I'm using cocoapods: pod 'SwiftyStoreKit', '0.15.0'

sabiland · 2022-09-17T13:12:51Z

Which version of SwiftyStoreKit are you using?

Always latest/updated as Swift package.

ArthurAlvarez · 2022-09-17T13:20:42Z

I was planning to release an updated version built with Xcode 14 but I guess I'll wait a while then

joseph2166 · 2022-09-18T08:53:23Z

I can confirm that this is happening on iOS 16 even when build with Xcode 13.

Reiszecke · 2022-09-18T12:20:50Z

https://zenn.dev/ch3cooh/scraps/5a907126170634 (use Google Translate to translate the page) has some more insight on this. The most important bit is that one:

I confirmed that the callback of paymentQueueController.restorePurchases was not returned.

    fileprivate func restorePurchases(atomically: Bool = true, applicationUsername: String = "", completion: @escaping (RestoreResults) -> Void) {
        
        paymentQueueController.restorePurchases(RestorePurchases(atomically: atomically, applicationUsername: applicationUsername) { results in
            
            let results = self.processRestoreResults(results)
            completion(results)
        })
    }

I've kind of given up on the whole SwiftyStoreKit thing but now that this person has been able to estimate a cause there may actually be some hope

Reiszecke · 2022-09-18T12:33:12Z

@CH3COOH sorry for the tag, just found your GH - what's your status now? Did you figure out anything else regarding SwiftyStoreKit or did you drop it entirely and go fully StoreKit 2?

CH3COOH · 2022-09-18T13:02:10Z

I investigated the success or failure of the combination of Xcode and Testflight/AppStore. I was able to restore if I used a combination of Xcode 14 and App Store. I am installing SwiftyStoreKit with Carthage.

Xcode	iOS	source	restore	app
13.4.1	16	App Store	OK	MyApp P
13.4.1	16	App Store	OK	MyApp S
13.4.1	16	Testflight	NG🙅‍♂️	MyApp P
13.4.1	16	Testflight	NG🙅‍♂️	MyApp S
13.4.1	15.7	App Store	OK	MyApp P
13.4.1	15.7	App Store	OK	MyApp S
13.4.1	15.7	Testflight	OK	MyApp S
13.4.1	14.8	Testflight	OK	MyApp S
14.0	16	App Store	OK🙆	MyApp F
14.0	16	Testflight	NG🙅‍♂️	MyApp F
14.0	16	Testflight	NG🙅‍♂️	MyApp P
14.0	16	Xcode Debug	NG🙅‍♂️	SwiftyStoreKit demo app
14.1 Beta	16	Xcode Debug	NG🙅‍♂️	SwiftyStoreKit demo app

CH3COOH · 2022-09-18T13:48:32Z

@Reiszecke

This bug is that restoreCompletedTransactionsFailedWithError or paymentQueueRestoreCompletedTransactionsFinished in PaymentQueueController is not called.

SwiftyStoreKit/Sources/SwiftyStoreKit/PaymentQueueController.swift

Lines 265 to 271 in f3265c7

    
           func paymentQueue(_ queue: SKPaymentQueue, restoreCompletedTransactionsFailedWithError error: Error) { 
        
               restorePurchasesController.restoreCompletedTransactionsFailed(withError: error) 
        
           } 
        
           func paymentQueueRestoreCompletedTransactionsFinished(_ queue: SKPaymentQueue) { 
        
               restorePurchasesController.restoreCompletedTransactionsFinished() 
        
           }

However, we were unable to discover why the callback was not called in the case of the combination of Xcode 14 and Testflight.

I would like to fix SwiftyStoreKit, but I have no knowledge of StoreKit 1 and cannot fix it. If I can't fix it after investigating for a while, I would like to move to StoreKit 2.

ArthurAlvarez · 2022-09-19T14:17:27Z

I still haven't been able to reproduce this error with my apps, I just tested submitting new builds to TestFlight integrating SwiftyStoreKit from Carthage and SPM and both work fine for me too on my iPhone 11 Pro.

Maybe this problem could be related to the App Store region that you're using? My Apple ID account is Brazilian, with BRL as currency.

I'll submit one build to TestFlight review and share a link here so you can test if it is hanging on your devices

Reiszecke · 2022-09-20T00:16:45Z

@CH3COOH thank you for the insights - we have moved to SK2 now. Testing is a real pain but hopefully everything is going to work out now. Good luck to you too!

@ArthurAlvarez It's hard for me to estimate but I'd say I don't see this problem with all devices if I consider purchases and support requests.

You can do the link-sharing and I can tell you whether it worked or not if that helps you. I will probably say bye to SSK but not because I think it's at fault - it's because I think the issue is very likely with SK1, it seems like Apple tried to touch something they shouldn't have touched for iOS 16. Otherwise it doesn't make sense why iOS 16 behaves differently than iOS 15.

What's odd is that I can hardly find any other reports. I'd guess more than 90% of the apps on the App Store are on SK1 or on a library that depends on it.

Reiszecke · 2022-09-20T00:18:57Z

@joseph2166

I can confirm that this is happening on iOS 16 even when build with Xcode 13.

This is what I don't understand. It doesn't seem to affect everyone for some reason. Do you have bitcode enabled in your apps?

sabiland · 2022-09-20T04:25:28Z

@Reiszecke Testing SK2 with Xcode 14 is quite easy using StoreKit configuration file. Check it on google.

FYI, I also disabled Bitcode on my apps as suggested by Xcode 14.

ArthurAlvarez · 2022-09-20T14:49:31Z

Here is the Testflight link:
https://testflight.apple.com/join/kRV7inhy

In my device (iPhone 11 Pro - iOS 16.0) this build is restoring OK. Please check on your devices so we can try to determine if the problem is build-related.

Can someone also provide a Testflight link of some app that is failing to restore?

joseph2166 · 2022-09-20T14:56:59Z

Here is the Testflight link: https://testflight.apple.com/join/kRV7inhy

In my device (iPhone 11 Pro - iOS 16.0) this build is restoring OK. Please check on your devices so we can try to determine if the problem is build-related.

Can someone also provide a Testflight link of some app that is failing to restore?

As per the screenshot feedback I just sent through TestFlight, I’m just getting a spinning green Buy button

Reiszecke · 2022-09-20T16:01:50Z

Green button spun for 10 seconds (probably SK TF Sandbox delay)

I have first tried restoring because why not, did not work. Then I have purchased, purchase went through, was recognized. I have uninstalled, restored again, worked again.

iPhone SE 3rd gen iOS 16.

What's your dev machine setup? OS, Xcode version and bitcode enabled/disabled?

ArthurAlvarez · 2022-09-20T17:06:37Z

As per the screenshot feedback I just sent through TestFlight, I’m just getting a spinning green Buy button

Please wait a while for it to fetch the product. I don't know why but it is slow on TestFlight environment.

What's your dev machine setup? OS, Xcode version and bitcode enabled/disabled?

Macbook with M1 Pro processor, macOS Monterey, Xcode 14.0 (14A309), bitcode disabled

Reiszecke · 2022-09-20T17:14:38Z

Can everyone here comment their bitcode configurations? This may actually be the issue here. Checked with another app so so far we have

App	Bitcode?	Xcode 14?	SSK iOS 14?
Reiszecke 1	✅	❌	❌
Reiszecke 2	❌	❌	✅
Arthur 1	❌	✅	✅

@sabiland I'm not sure if I understood what apps of yours are bitcode and which ones aren't - can you elaborate the missing info?

| Sabi 1 |  |  | 
| Sabi 2 |  |  | 
| Sabi 3 |  |  |

ArthurAlvarez · 2022-09-28T20:10:53Z

So we don't have any development on this... Are you all moving away from SwiftyStoreKit or this problem just happens in Sandbox?

Reiszecke · 2022-09-28T20:18:05Z

If I understood correctly you didn't have any issues in your non-bitcode app. I think that's the key, you don't need to do anything on your end I guess. SSK is pretty much on hold anyway.

I moved away from SSK to SK2 now because I couldn't afford messing around with build settings etc. and releasing a potentially breaking update so I have released whatever worked with TestFlight (automatic Sandbox) accounts and released that.

ArthurAlvarez · 2022-09-28T20:23:48Z

If I understood correctly you didn't have any issues in your non-bitcode app. I think that's the key, you don't need to do anything on your end I guess. SSK is pretty much on hold anyway.

I moved away from SSK to SK2 now because I couldn't afford messing around with build settings etc. and releasing a potentially breaking update so I have released whatever worked with TestFlight (automatic Sandbox) accounts and released that.

Just for curiosity, are you using a library that wraps SK2 or implementing it directly?

Reiszecke · 2022-09-29T07:54:37Z

Was thinking about using tikhop/Mercato#4 but the issue sounded too risky, so it's native SK2 without any library. RevenueCat is also fairly simple to add however if you browse through their forums, they have also messed up something in their code more than once so far so that's another risk I would only take for a temporary hotfix. In other words unless we see any issues with native SK2 it's probably the best decision to bite the bullet and move over to SK2. Testing is still an absolute nightmare tho.

About adding the code; SK2 really is much simpler than SK1 - the implementation code amount required is fairly similar to SSK. I think Apple could've made this A LOT simpler still by simply providing a singleton that has getters for each IAP identifier but I doubt there will ever be a SK3 so it probably won't get better than this, ever

sabiland · 2022-09-29T09:07:13Z

I refactored 3 my apps to Mercato, no problems so far. Though I only use 1 non-consumable IAP.

Reiszecke · 2022-09-29T09:35:30Z

Yeah I'm simply afraid of Mercato breaking in future just like SSK broke for some reason. Users are (understandably) very sensitive when it comes to purchase errors, they are quick to call you a scam etc. so the risk of using a lib with 41 stars was too high for me this time.

rockylive · 2022-09-29T23:51:05Z

I'm also facing this issue running on Xcode 14. Restore hangs

sabiland · 2022-09-30T04:02:54Z

Yeah I'm simply afraid of Mercato breaking in future just like SSK broke for some reason.

It seems SK2 is quite easy for manually to implement and as I checked Mercato code, it’s also quite straightforward.

And another thing (I did not know about this until recently), IAP can so easily be tested locally with StoreKit configuration file.

ArthurAlvarez · 2022-09-30T12:33:26Z

And another thing (I did not know about this until recently), IAP can so easily be tested locally with StoreKit configuration file.

This Xcode testing also works with SK1, I have tested my app both with SSK and using this Mercato Library and one thing that I found is that when SSK restores a purchase, instead of only validating the existing transaction, it creates a new transaction with the same ID of the original one, so if you restore a bunch of times you will end up with a lot of transactions on the debug menu.

Maybe this behavior could be a hint to the problem

mercadodiego · 2022-09-30T13:28:48Z

Guys I finally migrated to StoreKit2 and it was more easy than expected. Also I had important issues with Testflight versions and the damn sandbox server. So I finally figure out that after doing a phone reset and using a single apple id (don't ever change it if you can) everything worked as expected. Hope it helps

mercadodiego · 2022-09-30T13:30:15Z

I would like to add that I published this using Version 14.0.1 (14A400). Also our CI Server has an outdated version and I think that was an issue too.

astrokin · 2022-10-09T20:27:02Z

@mercadodiego as far as i understand the issue was not in code but in the environment?

syzlztt · 2022-10-11T07:23:11Z

I think Apple fixed this bug in iOS 16.0.3 .

CH3COOH · 2022-10-11T23:59:40Z

The combination of Xcode 14.0, iOS 16.0.3 and Testflight did not fix this problem...

mercadodiego · 2022-10-12T17:53:50Z

The combination of Xcode 14.0, iOS 16.0.3 and Testflight did not fix this problem...

Yep, that's why I had to migrate to StoreKit2

mercadodiego · 2022-10-12T17:55:36Z

@mercadodiego as far as i understand the issue was not in code but in the environment?

@CH3COOH after I migrated to StoreKit2 I found issues with the environment as I described above. A factory reset seems to resolve the issue I was having only on my phone.

CH3COOH · 2022-10-25T08:39:10Z

I have confirmed that it works with Xcode 14.1 RC2, iOS 16.1 and a combination of TestFlight and SwiftyStoreKit, and my app was able to restore.

I would appreciate it if you could also check if you are having this issue.

powhu · 2022-12-05T05:32:55Z

I have confirmed that it works with Xcode 14.1 RC2, iOS 16.1 and a combination of TestFlight and SwiftyStoreKit, and my app was able to restore.
I would appreciate it if you could also check if you are having this issue.

Confirmed.
Xcode 14.1, iOS 16.1 TestFlight fixed.

frogg · 2023-01-21T23:07:18Z

Is there any info on restoring one-time purchases on macOS 13?
Seems like this is fixed on iOS 16.2, but not on macOS 13.1?

sabiland added the type: question label Sep 13, 2022

VitalyKnyazev mentioned this issue Sep 30, 2022

iOS simulator GetPurchasesAsync is not returning or giving an error jamesmontemagno/InAppBillingPlugin#499

Closed

Reiszecke mentioned this issue Dec 15, 2022

Apple Watch Restore Purchases issue RevenueCat/purchases-ios#2132

Closed

iOS 16 (am not sure) restoring purchases hangs? #682

iOS 16 (am not sure) restoring purchases hangs? #682

Comments

sabiland commented Sep 13, 2022 • edited Loading

Restoring purchases hangs

Reiszecke commented Sep 15, 2022

CH3COOH commented Sep 15, 2022

sabiland commented Sep 16, 2022

mercadodiego commented Sep 16, 2022

ArthurAlvarez commented Sep 17, 2022

sabiland commented Sep 17, 2022 • edited Loading

ArthurAlvarez commented Sep 17, 2022

Reiszecke commented Sep 17, 2022

sabiland commented Sep 17, 2022 • edited Loading

ArthurAlvarez commented Sep 17, 2022

sabiland commented Sep 17, 2022

ArthurAlvarez commented Sep 17, 2022

joseph2166 commented Sep 18, 2022

Reiszecke commented Sep 18, 2022

Reiszecke commented Sep 18, 2022

CH3COOH commented Sep 18, 2022

CH3COOH commented Sep 18, 2022

ArthurAlvarez commented Sep 19, 2022

Reiszecke commented Sep 20, 2022

Reiszecke commented Sep 20, 2022

sabiland commented Sep 20, 2022 • edited Loading

ArthurAlvarez commented Sep 20, 2022 • edited Loading

joseph2166 commented Sep 20, 2022

Reiszecke commented Sep 20, 2022

ArthurAlvarez commented Sep 20, 2022

Reiszecke commented Sep 20, 2022 • edited Loading

ArthurAlvarez commented Sep 28, 2022

Reiszecke commented Sep 28, 2022

ArthurAlvarez commented Sep 28, 2022

Reiszecke commented Sep 29, 2022

sabiland commented Sep 29, 2022

Reiszecke commented Sep 29, 2022

rockylive commented Sep 29, 2022

sabiland commented Sep 30, 2022

ArthurAlvarez commented Sep 30, 2022

mercadodiego commented Sep 30, 2022

mercadodiego commented Sep 30, 2022

astrokin commented Oct 9, 2022

syzlztt commented Oct 11, 2022

CH3COOH commented Oct 11, 2022

mercadodiego commented Oct 12, 2022

mercadodiego commented Oct 12, 2022

CH3COOH commented Oct 25, 2022

powhu commented Dec 5, 2022

frogg commented Jan 21, 2023

sabiland commented Sep 13, 2022 •

edited

Loading

sabiland commented Sep 17, 2022 •

edited

Loading

sabiland commented Sep 17, 2022 •

edited

Loading

sabiland commented Sep 20, 2022 •

edited

Loading

ArthurAlvarez commented Sep 20, 2022 •

edited

Loading

Reiszecke commented Sep 20, 2022 •

edited

Loading