-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leaks #120
Comments
Would be good to check for similar leaks once the PR is merged. |
@huangboju would be good if you could retest this on version 0.7.0. If there are no updates to this issue in the coming weeks I will close it. |
I think same things could be found in DispatchQueue.main.async {
self.callback(...
} could be DispatchQueue.main.async { [unowned self] in
self.callback(...
} or DispatchQueue.main.async { [weak self] in
guard let this = self else { /*log, or send error somewhere...*/; return }
this.callback(...
} |
@phimage good point. I'm aiming to fix this in the next minor release. |
@huangboju Just noticed you reported a leak on |
@bizz84 Thanks |
The text was updated successfully, but these errors were encountered: