Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaks #120

Closed
huangboju opened this issue Dec 20, 2016 · 6 comments
Closed

Leaks #120

huangboju opened this issue Dec 20, 2016 · 6 comments
Assignees

Comments

@huangboju
Copy link

2016-12-20 2 50 31

2016-12-20 2 50 23

2016-12-20 2 50 07

@bizz84
Copy link
Owner

bizz84 commented Jan 21, 2017

InAppProductPurchaseRequest will be removed here: #131.

Would be good to check for similar leaks once the PR is merged.

@bizz84
Copy link
Owner

bizz84 commented Feb 4, 2017

@huangboju would be good if you could retest this on version 0.7.0. If there are no updates to this issue in the coming weeks I will close it.

@phimage
Copy link
Contributor

phimage commented Feb 20, 2017

I think same things could be found in InAppProductQueryRequest

 DispatchQueue.main.async {
            self.callback(...
        }

could be

 DispatchQueue.main.async {  [unowned self] in
            self.callback(...
        }

or

 DispatchQueue.main.async {  [weak self] in
            guard let this = self else { /*log, or send error somewhere...*/; return }
            this.callback(...
        }

@bizz84
Copy link
Owner

bizz84 commented Feb 20, 2017

@phimage good point. I'm aiming to fix this in the next minor release.

@bizz84
Copy link
Owner

bizz84 commented Feb 22, 2017

@huangboju Just noticed you reported a leak on InAppProductQueryRequest, not InAppProductPurchaseRequest, so this issue still stands. Working on a fix now.

@huangboju
Copy link
Author

huangboju commented Feb 23, 2017

@bizz84 Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants