Create a variable to specify certbot related IP binding

[Aaron-Ritter]

Hi,

Similar to issue #125 it would be good to allow the same for the letsencrypt certbot container, could you please add a bind IP question during the bitwarden.sh install part in the letsencrypt section.

server/scripts/run.sh

Lines 65 to 77 in 36e97cc

	if [ "$LETS_ENCRYPT" == "y" ]
	then
	echo -e -n "${CYAN}(!)${NC} Enter your email address (Let's Encrypt will send you certificate expiration reminders): "
	read EMAIL
	echo ""
	mkdir -p $OUTPUT_DIR/letsencrypt
	docker pull certbot/certbot
	docker run -it --rm --name certbot -p 80:80 -v $OUTPUT_DIR/letsencrypt:/etc/letsencrypt/ certbot/certbot \
	certonly --standalone --noninteractive --agree-tos --preferred-challenges http \
	--email $EMAIL -d $DOMAIN --logs-dir /etc/letsencrypt/logs
	fi
	fi

And something similar with (or storing the information for later in the previous step):

server/scripts/run.sh

Lines 116 to 123 in 36e97cc

	function updateLetsEncrypt() {
	if [ -d "${OUTPUT_DIR}/letsencrypt/live" ]
	then
	docker pull certbot/certbot
	docker run -i --rm --name certbot -p 443:443 -p 80:80 \
	-v $OUTPUT_DIR/letsencrypt:/etc/letsencrypt/ certbot/certbot \
	renew --logs-dir /etc/letsencrypt/logs
	fi

or maybe instead making it part of the docker-compose.yml?

Thanks
Aaron

[Aaron-Ritter]

e.g.

        if [ "$LETS_ENCRYPT" == "y" ]
        then
            echo -e -n "${CYAN}(!)${NC} Enter your email address (Let's Encrypt will send you certificate expiration reminders): "
            read EMAIL
            echo ""
            echo -e -n "${CYAN}(!)${NC} Specify an IP for certbot to listen on, otherwhise leave blank: "
            read CERTBOTIPINPUT
            echo ""
            if [ -z "$CERTBOTIPINPUT" ]
            then
                CERTBOTIP=0.0.0.0
            else
                CERTBOTIP=$CERTBOTIPINPUT
            fi

            mkdir -p $OUTPUT_DIR/letsencrypt
            docker pull certbot/certbot
            docker run -it --rm --name certbot -p $CERTBOTIP:80:80 -v $OUTPUT_DIR/letsencrypt:/etc/letsencrypt/ certbot/certbot \
                certonly --standalone --noninteractive  --agree-tos --preferred-challenges http \
                --email $EMAIL -d $DOMAIN --logs-dir /etc/letsencrypt/logs
        fi
    fi

[PeterSurda]

I second this. Please fix. If you have a system with multiple IP addresses, this prevents you from running any other webserver on the other IPs.

[dmascord]

Agree, this needs to be fixed for servers with multiple IPs.

[cscharf]

Added to our DevOps board. Thanks!

[bitwarden-bot]

Hi @Aaron-Ritter,
We're cleaning up our repositories in preparation for a major reorganization. Issues from last year will be marked as stale and closed after two weeks. If you still need help, comment to let us know and we'll look into it.
Thanks!