From 890becc091ab69d154043149d4b4177d41a884a2 Mon Sep 17 00:00:00 2001
From: tangowithfoxtrot <5676771+tangowithfoxtrot@users.noreply.github.com>
Date: Mon, 24 Nov 2025 08:36:02 -0800
Subject: [PATCH 1/4] style: deny usage of #[allow()]; prefer #[expect()]

---
 Cargo.toml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Cargo.toml b/Cargo.toml
index c21b61c55..fbb4dccf6 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -29,6 +29,7 @@ schemars = { version = ">=0.8.9, <0.9", features = ["uuid1", "chrono"] }
 tokio = { version = "1.36.0", features = ["macros"] }
 
 [workspace.lints.clippy]
+allow-attributes = "deny"
 unused_async = "deny"
 unwrap_used = "deny"
 

From 2e541828ffe1097fad96537abfdb6856a4c0e47b Mon Sep 17 00:00:00 2001
From: tangowithfoxtrot <5676771+tangowithfoxtrot@users.noreply.github.com>
Date: Mon, 24 Nov 2025 08:37:53 -0800
Subject: [PATCH 2/4] misc: #[allow()] -> #[expect()]

---
 crates/bws/src/cli.rs          | 4 ++--
 crates/bws/src/main.rs         | 1 -
 crates/bws/src/util.rs         | 2 +-
 crates/sdk-schemas/src/main.rs | 2 +-
 4 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/crates/bws/src/cli.rs b/crates/bws/src/cli.rs
index 7846166fe..cc5a7f003 100644
--- a/crates/bws/src/cli.rs
+++ b/crates/bws/src/cli.rs
@@ -14,7 +14,7 @@ pub(crate) const UUIDS_AS_KEYNAMES_VAR_NAME: &str = "BWS_UUIDS_AS_KEYNAMES";
 pub(crate) const DEFAULT_CONFIG_FILENAME: &str = "config";
 pub(crate) const DEFAULT_CONFIG_DIRECTORY: &str = ".config/bws";
 
-#[allow(non_camel_case_types)]
+#[expect(non_camel_case_types)]
 #[derive(Copy, Clone, PartialEq, Eq, PartialOrd, Ord, ValueEnum, Debug)]
 pub(crate) enum ProfileKey {
     server_base,
@@ -25,7 +25,7 @@ pub(crate) enum ProfileKey {
 }
 
 #[derive(Copy, Clone, PartialEq, Eq, PartialOrd, Ord, ValueEnum, Debug)]
-#[allow(clippy::upper_case_acronyms)]
+#[expect(clippy::upper_case_acronyms)]
 pub(crate) enum Output {
     JSON,
     YAML,
diff --git a/crates/bws/src/main.rs b/crates/bws/src/main.rs
index 4a1818ac1..d5c74f7da 100644
--- a/crates/bws/src/main.rs
+++ b/crates/bws/src/main.rs
@@ -27,7 +27,6 @@ async fn main() -> Result<()> {
     process_commands().await
 }
 
-#[allow(clippy::comparison_chain)]
 async fn process_commands() -> Result<()> {
     let cli = Cli::parse();
     let color = cli.color;
diff --git a/crates/bws/src/util.rs b/crates/bws/src/util.rs
index a86f0f569..3796fc7a7 100644
--- a/crates/bws/src/util.rs
+++ b/crates/bws/src/util.rs
@@ -27,7 +27,7 @@ pub(crate) fn uuid_to_posix(uuid: &Uuid) -> String {
 }
 
 mod tests {
-    #[allow(unused_imports)]
+    #[expect(unused_imports)]
     use super::*;
 
     #[test]
diff --git a/crates/sdk-schemas/src/main.rs b/crates/sdk-schemas/src/main.rs
index a5d38ca4d..ea1abf058 100644
--- a/crates/sdk-schemas/src/main.rs
+++ b/crates/sdk-schemas/src/main.rs
@@ -87,7 +87,7 @@ fn write_schema(schema: RootSchema, dir_path: String, type_name: String) -> Resu
 
 use bitwarden_json::response::Response;
 
-#[allow(dead_code)]
+#[expect(dead_code)]
 #[derive(JsonSchema)]
 struct SchemaTypes {
     // Input types for new Client

From 634706fedf9c10af940bc5b96d454aa83366c832 Mon Sep 17 00:00:00 2001
From: tangowithfoxtrot <5676771+tangowithfoxtrot@users.noreply.github.com>
Date: Mon, 24 Nov 2025 08:39:34 -0800
Subject: [PATCH 3/4] misc: unused_imports is not needed

---
 crates/bws/src/util.rs | 1 -
 1 file changed, 1 deletion(-)

diff --git a/crates/bws/src/util.rs b/crates/bws/src/util.rs
index 3796fc7a7..7a573f321 100644
--- a/crates/bws/src/util.rs
+++ b/crates/bws/src/util.rs
@@ -27,7 +27,6 @@ pub(crate) fn uuid_to_posix(uuid: &Uuid) -> String {
 }
 
 mod tests {
-    #[expect(unused_imports)]
     use super::*;
 
     #[test]

From fb6bcfb85fb287903c834c3aeca5a01005930a6d Mon Sep 17 00:00:00 2001
From: tangowithfoxtrot <5676771+tangowithfoxtrot@users.noreply.github.com>
Date: Mon, 24 Nov 2025 08:40:31 -0800
Subject: [PATCH 4/4] fix: test was not properly configured

these tests were being compiled into the release
binaries instead of being treated as unit tests
---
 crates/bws/src/util.rs | 1 +
 1 file changed, 1 insertion(+)

diff --git a/crates/bws/src/util.rs b/crates/bws/src/util.rs
index 7a573f321..85c8d2546 100644
--- a/crates/bws/src/util.rs
+++ b/crates/bws/src/util.rs
@@ -26,6 +26,7 @@ pub(crate) fn uuid_to_posix(uuid: &Uuid) -> String {
     format!("_{}", uuid.to_string().replace('-', "_"))
 }
 
+#[cfg(test)]
 mod tests {
     use super::*;