-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firefox Extension - Uncaught Error: Permission denied to access property #7837
Comments
Took a look into this a bit, and was able to replicate the issue. So this problem exists for a couple of reasons, it's due to a combination between our usage of custom web components in the inline menu, incompatibilities that Firefox has with custom web components within extension content scripts, and the implementation details of The inline menu uses custom web components to impede programmatic access to the content within the inline menu. We use a polyfill that facilitates this behavior within a content script context, as browser support in this regard is still catching up to the official spec. In Chromium browsers and Safari, we don't seem to have any issues with accessing properties of these custom web components. Firefox on the other hand throws a 'Permission Denied' error anytime a property is accessed on a web component created within a content script. So with that said, At the moment I'm not sure what we can do to resolve this issue directly. We'll add this to our backlog to see if we can find some kind of solution, but finding a resolution to this from our side might be challenging. Beyond that, either Booking.com has to resolve how they handle this kind of error on their website or Mozilla has to resolve the bugs that Firefox experiences with web components. For now, I'd recommend you use other means for autofilling the credentials on this website. It seems that either using the keyboard shortcut, context menu, or the popup to autofill works as expected. This is due to the fact that we do not inject any custom web components into the page, which avoids introducing the side effect behavior from the One Trust plugin. |
I was not aware of the context menu option. It works as expected. So this bug might be something to be addressed by Mozilla. |
Hey @cagonzalezcs, could this possibly be re-opened? The issue occurs for seemingly all React apps (at least as of v18). React's mouse/pointer event listeners throw this error when interacting with the inline autofill due to Firefox's noted web component issues. Ideally, Firefox's bugs should be fixed, but I would think that the React ecosystem is large enough to warrant a fix/workaround on Bitwarden's side in lieu of Firefox fixing it upstream. See https://codepen.io/breakthestatic/pen/oNOLRqd for a simple React demo exhibiting the issue. |
@cdonovan This issue is open, but not within this ticket - #8063 With that said, the only way that I see our team addressing this is by making the decision to remove custom elements within the inline menu. We use custom elements and a closed ShadowDOM to impede programmatic access to the UI elements that render the inline menu. I can bring up that consideration with Bitwarden's leadership, but I'm fairly certain that there will be resistance towards moving the implementation towards a less secure approach. Please feel free to comment on the other thread with ideas for how this might be worked around though. I left that thread open to facilitate discussion, as I was aware that we would likely run into concerns for this again. |
I have the exact same problem using Bitwarden on Chrome. I did not have the problem when I was using 1password on Chrome |
Steps To Reproduce
Expected Result
The Email address field should be automatically filled in with the saved username.
Actual Result
The field remains blank. Using the browser's developer tools, there is the following error on the console:
Screenshots or Videos
booking.com-bitwarden-issue.mp4
Additional Context
The site works fine with the same version of the Bitwarden extension running on Google Chrome.
Operating System
Windows
Operating System Version
11
Web Browser
Firefox
Browser Version
122.0.1
Build Version
2024.1.1
Issue Tracking Info
The text was updated successfully, but these errors were encountered: