Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #460 transfer qty validation issue #466

Merged
merged 3 commits into from
Sep 29, 2017
Merged

Conversation

ariesjia
Copy link
Contributor

fix issue #460

@svk31
Copy link
Contributor

svk31 commented Sep 29, 2017

This looks OK, but it doesn't fix the account validation. The issue is that the variable to_account is only updated when a valid account is found, so if you change the input text to a non-valid account name, the old account name is still kept. I suggest you add a toAccountValid variable to the if check you already used here:

const toAccountValid = to_account && to_account.get("name") === this.state.to_name;
if(!from_account || !to_account || !toAccountValid .......

@ariesjia
Copy link
Contributor Author

ariesjia commented Sep 29, 2017

@svk31 Thanks for your detail solution , I update toAccount validation code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants