[10] Show more/all history for 'My Trades' in the DEX

[svk31]

From @steempower on January 13, 2017 5:20

The 'My trades' box within the DEX should provide a longer history of trades by default and include a button to show all trades which would fetch the entire history of the users trades for that market pair

Copied from original issue: cryptonomex/graphene-ui#895

[wmbutler]

This needs an infinite scrolling strategy.

[abitmore]

When exporting the history as csv, the filename defaults to using zero-based month which may be confusing to end users.

Example: btshist-2017-6-22.csv is generated for a history exported on July 22.

Best report it as a separate issue. Thanks.

[Ashaman-]

Is it possible to have the wallet save trade history locally? And if there are gaps due to a wallet being offline when a bunch of orders execute, maybe it can use get_relative_account_history to fill them in?

[wmbutler]

@Ashaman- Your question is unrelated to the issue. I do not think the wallet should store history. The wallet should query the API to obtain the history.

[wmbutler]

As I think about this, paging would be the easiest to implement.

[abitmore]

As I think about this, paging would be the easiest to implement.

It may require API support/changes. but I'm not sure. Please open an issue in the bitshares-core repository. Or ask in the dev channel first.

[wmbutler]

Mentioned this in the dev channel.

[wmbutler]

get_relative_account_history(account_id_type account, uint32_t stop = 0, unsigned limit = 100, uint32_t start = 0) const

Get operations relevant to the specified account referenced by an event numbering specific to the account. The current number of operations for the account can be found in the account statistics (or use 0 for start).

Return

A list of operations performed by account, ordered from most recent to oldest.

Parameters

• account: The account whose history should be queried
• stop: Sequence number of earliest operation. 0 is default and will query ‘limit’ number of operations.
• limit: Maximum number of operations to retrieve (must not exceed 100)
• start: Sequence number of the most recent operation to retrieve. 0 is default, which will start querying from the most recent operation.

[wmbutler]

In order to fully satisfy this requirement, we need to be able to optionally request:

• type of operation ( transfer / cancel order / place order .... )
• date/time range
• trading pair

in addition to the features of get_relative_account_history

[abitmore]

Just a note here, there is a get_account_history API with a type filter, but the implementation is inefficient and hard to improve as of writing, so I won't recommend that. Yes, we can improve the get_relative_account_history API, but perhaps need to create a new API for backward compatibility.

[wmbutler]

@oxarbitrage just touching base on the api progress for this?

[oxarbitrage]

yes, sorry the delay @wmbutler. i had been working very hard over the last 2 weeks to get this done the right way, this is affecting performance and memory usage the less possible while returning the exact results inside the requested time range. it haves some technical difficulties because of how the implementation is designed, i have a solution, actually i already presented several, this last one is the most close to optimal we can think of. solution will also be of use for other issues we have in bitshares-core. i am getting guidance by @pmconrad and i know i told this several times but it should be ready very soon, this week i hope. i can say i am working non stop to make this pull request happened and move on to something else.

[wmbutler]

Not a problem. I just want to know if I should delay it. I'll move it to 171015 for now.

[wmbutler]

@oxarbitrage this issue specifically is requesting for a given trading pair. Did you build in the ability to filter to a trading pair as well? I know this is going to help for the overall trading history but couldn't remember the answer to this question.

[oxarbitrage]

Hi @wmbutler sorry for the late response, mention was while i was travelling and i didn't saw it until now. as you probably know we are working in a global solution to browse the account history in all ways needed included filtering by the assets, operation type or anything.
To do this we are moving the account data history to disk, reducing the ram needed by a full node too. Ill recommend you to move all the account_history related issues to 171101 milestone.

[wmbutler]

@oxarbitrage checking in on this again. Will this be ready for the 171101 release?

[wmbutler]

@oxarbitrage will I need to push this to 171115?

[kohako]

While waiting for this update is there a way to view the market trades for a pair somewhere else ?

[startailcoon]

http://open-explorer.io/ is a good start to look at

[clockworkgr]

Is anyone working on this? With the increased chain size since OP creation this is impossible with the standard API.

Will either have to be done via ES calls or not at all.

Do we have an epic about integrating ES data ?

[sschiessl-bcp]

Yes there is one, we have been mostly waiting to ensure that ES backend has matured and doesn't change interfaces / indices anymore. I suppose that could now be re-evaluated.

For the reference UI we would need reliable ES backends though, and right now the only one is the infrastructure worker (which is not active atm), plus 2 from the community with no guarantee of service. So in that state it is not feasible to work on heavy ES integration.

The sole ES integration right now is account history export.