Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3] Non committee/witness (private) feed producers within UI? #452

Closed
grctest opened this issue Sep 25, 2017 · 12 comments
Closed

[3] Non committee/witness (private) feed producers within UI? #452

grctest opened this issue Sep 25, 2017 · 12 comments
Assignees
Labels
[3] Feature Classification indicating the addition of novel functionality to the design
Milestone

Comments

@grctest
Copy link
Contributor

grctest commented Sep 25, 2017

HERO uses private feed producers (who are not strictly members of the committee/witnesses): https://github.com/hero-global/scripts/blob/master/hero-setup.py#L24

It's possible to do this using uptick or the bitshares_python tools, but not possible to do this within the BTS UI.

@wmbutler
Copy link
Contributor

"It's possible to do this"

You are going to need to be more specific. What feature are you asking for?

@o5j5vg55bv5hv5j5f8799f9

I think he means adding sources for feeds. You can see them here https://bitshares.org/wallet/#/asset/HERO but I guess he wants

hero.update_feed_producers([
    "blckchnd",
    "delegate.ihashfury",
    "rnglab",
    "taconator-witness",
    "verbaltech2",
    "delegate-1.lafona",
    "roelandp",
    "wackou",
    "spartako",
    "sahkan-bitshares",
])

to be editable in asset creation/edit in gui.

@grctest
Copy link
Contributor Author

grctest commented Sep 25, 2017

@o5j5vg55bv5hv5j5f8799f9 Thanks, yeah this is what I meant.

The bitshares documentation lists that only witnesses and committee members are able to publish price feed updates, but HERO has implemented a separate list of price feed publishers whom are not (AFAIK) witnesses nor committee members.

It'd something that would likely be seldomly configured, however its existence is not well documented and seems to have only been implemented within the HERO MPA. The ability to configure this within the UI may lead to new MPAs being created.

@wmbutler
Copy link
Contributor

It seems to me that this would be implemented in whatever HERO wallet comes around. Does it make sense for the reference wallet?

@svk31
Copy link
Contributor

svk31 commented Sep 25, 2017

It's not HERO specific, that's just an example. Any private bit asset can define their own set of feed publishers, they're just asking for that to be added to the GUI in the asset create and update screens.

@wmbutler
Copy link
Contributor

Ok, so maybe I UX an area in the Asset Explorer to include the list of feed producers?

@o5j5vg55bv5hv5j5f8799f9
Copy link

o5j5vg55bv5hv5j5f8799f9 commented Sep 26, 2017

Ok, so maybe I UX an area in the Asset Explorer to include the list of feed producers?

public viewable list of feed producers already exists, like example bottom of https://bitshares.org/wallet/#/asset/HERO

he means specifically here https://bitshares.org/wallet/#/account/USERNAME/create-asset/ (substitute your own name)

@grctest
Copy link
Contributor Author

grctest commented Sep 26, 2017

he means specifically here https://bitshares.org/wallet/#/account/USERNAME/create-asset/ (substitute your own name)

Yeah, a similar interface to add feed producers for a private MPA as selecting witnesses/committee members in the voting page (via a search box).

@wmbutler
Copy link
Contributor

Got it. So a way to search for and build the feed producers array witihn the asset creation area. I will UX>

@wmbutler wmbutler self-assigned this Sep 27, 2017
@wmbutler wmbutler added [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [3] Feature Classification indicating the addition of novel functionality to the design and removed question [3] Enhancement Classification indicating a change to the functionality of the existing imlementation labels Sep 27, 2017
@wmbutler wmbutler added this to the 171015 milestone Sep 27, 2017
@wmbutler wmbutler added the [4c] High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive label Oct 1, 2017
@wmbutler wmbutler modified the milestones: 171015, 171101 Oct 9, 2017
@wmbutler
Copy link
Contributor

You can put this in place the same way you did UIA whitelisting, although you need to limit the eligible accounts to just witnesses.

@wmbutler wmbutler changed the title Non committee/witness (private) feed producers within UI? [3] Non committee/witness (private) feed producers within UI? Oct 15, 2017
@grctest
Copy link
Contributor Author

grctest commented Oct 15, 2017

although you need to limit the eligible accounts to just witnesses.

How come? You can have committee & user-selected "private" publishers. Are only the witnesses available to display within the UI?

@wmbutler
Copy link
Contributor

How come? You can have committee & user-selected "private" publishers. Are only the witnesses available to display within the UI?

Ah, I did not know that.

@wmbutler wmbutler removed their assignment Oct 23, 2017
@svk31 svk31 modified the milestones: 171101, 171115 Oct 30, 2017
@svk31 svk31 removed the [4c] High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive label Nov 16, 2017
@wmbutler wmbutler modified the milestones: 171119, 171201 Nov 16, 2017
@wmbutler wmbutler removed this from the 171205 milestone Dec 5, 2017
@wmbutler wmbutler added this to the 171215 milestone Dec 5, 2017
@svk31 svk31 self-assigned this Dec 8, 2017
@svk31 svk31 closed this as completed in 83a489b Dec 9, 2017
Cryptolero pushed a commit to CryptoBridge/cryptobridge-ui that referenced this issue Nov 2, 2018
* Adopt new confirm/reset button layout, fix some styling issues

* Fix tab <a> background-color animation

* Make li background-color animations same as for <a>s

* Fix bitshares#452: Add ability to define private feed producers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[3] Feature Classification indicating the addition of novel functionality to the design
Projects
None yet
Development

No branches or pull requests

4 participants