Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15][gibbsfromncis] Set Price Alerts #422

Closed
landry314 opened this issue Sep 18, 2017 · 19 comments
Closed

[15][gibbsfromncis] Set Price Alerts #422

landry314 opened this issue Sep 18, 2017 · 19 comments
Assignees
Labels
[3] Feature Classification indicating the addition of novel functionality to the design [7] Finalized Administartion flag, notifies hours are finalized
Milestone

Comments

@landry314
Copy link

Many trading interfaces have alert systems when a price is reached or when a certain percentage move occurs. It would be a nice addition to this platform to include such features.

Alerts could trigger a sound and/or a popup and/or an email sent to an address of choice.

@landry314
Copy link
Author

This is mentioned in #288 briefly.

@wmbutler wmbutler added the [3] Enhancement Classification indicating a change to the functionality of the existing imlementation label Sep 19, 2017
@fractalnode
Copy link

fractalnode commented Oct 25, 2017

It would also be nice to have an alarm below the specified (defined by user) value of Collateral Ratio

@wmbutler
Copy link
Contributor

Chrome Notifications can handle this. Let's start this off with alerts for:

  • Predetermined collateral value
  • Price target (enter as percentage or as fixed number, but stored as a fixed number either way)

@wmbutler wmbutler added this to the 180215 milestone Jan 15, 2018
@wmbutler wmbutler added the [3] Feature Classification indicating the addition of novel functionality to the design label Jan 15, 2018
@gibbsfromncis
Copy link
Contributor

gibbsfromncis commented Feb 15, 2018

@wmbutler I can integrate this to my Browser Notifications. But we need some UX for this on Exchange I guess. But make sure that Browser Notifications work only if tab opened. So we cannot support email notifications.

Will prepare my features proposal a little bit later and post them there as todo list

@gibbsfromncis
Copy link
Contributor

  • Add ability to enable/disable "Price Alert" browser notification on Settings -> Browser Notifications
  • (Simple) Add "Alarm" Icon on Exchange near Latest Price. When user click he can specify price at which he should receive the notification.
  • (Complex) Add "Alarm" Icon on Bids/Asks header. When user click on it he can specify price and minimal amount of order at which he should receive the notification.
  • Add Price Alert (idk where we can add this) manage section. We should have one place where user able to See/Delete/Add price alerts for different pairs.

price-alarm

@wmbutler wmbutler modified the milestones: 180215, 180301 Feb 17, 2018
@wmbutler wmbutler removed the [3] Enhancement Classification indicating a change to the functionality of the existing imlementation label Feb 17, 2018
@wmbutler wmbutler changed the title Create Price Alert Feature for the Exchange [3] Create Price Alert Feature for the Exchange Feb 17, 2018
@wmbutler wmbutler modified the milestones: 180301, 180501 Mar 1, 2018
@wmbutler
Copy link
Contributor

wmbutler commented Mar 1, 2018

Pushing this out pretty far. UX needed.

@wmbutler wmbutler added the [6] UX Impact flag identifying the application User Experience label Mar 1, 2018
@gibbsfromncis
Copy link
Contributor

@wmbutler if someone provide UX I can work on this one.

@wmbutler wmbutler changed the title [3] Create Price Alert Feature for the Exchange [3][gibbsfromncis] Create Price Alert Feature for the Exchange Mar 5, 2018
@gibbsfromncis gibbsfromncis self-assigned this Mar 24, 2018
@gibbsfromncis
Copy link
Contributor

@diogogomes What about now? Are you ready ?

@gibbsfromncis
Copy link
Contributor

@wmbutler what about this issue? Do we wait for UX from this task - #1263 ?

@wmbutler
Copy link
Contributor

wmbutler commented Apr 1, 2018

I guess so.

@gibbsfromncis gibbsfromncis modified the milestones: 180501, 180515 May 3, 2018
@gibbsfromncis
Copy link
Contributor

gibbsfromncis commented May 3, 2018

@wmbutler If I understand correct the UX is finished. I can implement Price Alerts but I have no idea how to notify users about these alerts. Bell UX was removed from diogo so we have only Price Setup UX.

Anyway we can use browser notifications but it as I said a lot of times before it works only if browser and wallet opened.

Or we can show specific message when user enters wallet first time for a while and if any alert passes.

@wmbutler
Copy link
Contributor

wmbutler commented May 3, 2018

We need to determine if this is the screen for setting alerts or reporting those alerts. I think if your just work on setting price alerts, you can route those requests to Chrome. We can later built a price alert screen for dismissing them, etc.

@wmbutler wmbutler added this to the 180905 milestone Aug 26, 2018
@wmbutler wmbutler modified the milestones: 180905, 180919 Sep 13, 2018
@wmbutler wmbutler modified the milestones: 180919, 181003 Sep 25, 2018
@gibbsfromncis
Copy link
Contributor

gibbsfromncis commented Sep 26, 2018

@wmbutler @startailcoon I'm so close to finish this task but I'm out of my estimate. Please increase it to 10h because there are a lot of hidden functionality I didn't have a chance to estimate like prices tracking, browsers notifications, price alerts managing (not only create modal) etc.

UX: photo_2018-04-23_16-22-02

@wmbutler wmbutler changed the title [5][gibbsfromncis] Set Price Alerts [10][gibbsfromncis] Set Price Alerts Sep 28, 2018
@wmbutler wmbutler added this to the 181017 milestone Sep 28, 2018
@gibbsfromncis gibbsfromncis modified the milestones: 181017, 181031 Oct 16, 2018
@gibbsfromncis gibbsfromncis modified the milestones: 181031, 181114 Nov 5, 2018
@gibbsfromncis
Copy link
Contributor

gibbsfromncis commented Nov 6, 2018

Notifications

screenshot 2018-11-06 03 29 12

Price Alert Icon

The price alert icon for now is placed on Exchange header near the pair names

screenshot 2018-11-06 03 08 00

It is blue when pair has notifications and simple when hasn't

Price Alert Manage

screenshot 2018-11-06 03 09 17

screenshot 2018-11-06 03 09 09

gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Nov 6, 2018
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Nov 6, 2018
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Nov 6, 2018
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Nov 6, 2018
@gibbsfromncis
Copy link
Contributor

@startailcoon it took a little bit more than I expected but now i'm familiar well with Market operations.

Final estimate: 15h

@gibbsfromncis gibbsfromncis mentioned this issue Nov 6, 2018
6 tasks
@wmbutler wmbutler changed the title [10][gibbsfromncis] Set Price Alerts [15][gibbsfromncis] Set Price Alerts Nov 6, 2018
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Nov 12, 2018
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Nov 12, 2018
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Nov 12, 2018
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Nov 12, 2018
gibbsfromncis added a commit to gibbsfromncis/bitshares-ui that referenced this issue Nov 12, 2018
@startailcoon startailcoon added the [7] Finalized Administartion flag, notifies hours are finalized label Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[3] Feature Classification indicating the addition of novel functionality to the design [7] Finalized Administartion flag, notifies hours are finalized
Projects
None yet
Development

No branches or pull requests

5 participants