Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1][react-cat] Market picker select nonexistent trading pair #3018

Open
react-cat opened this issue Aug 8, 2019 · 7 comments
Open

[1][react-cat] Market picker select nonexistent trading pair #3018

react-cat opened this issue Aug 8, 2019 · 7 comments
Labels
[1b] User Story The User Story details a requirement. It may ref a parent Project (Epic). It may ref child Task(s) [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [5a] Tiny Indicates size of task. Est. less than one hour

Comments

@react-cat
Copy link
Contributor

Describe the bug
User have an ability to select nonexistent trading pair what causes crash of market picker

To Reproduce
Steps to reproduce the behavior:

  1. Go to market
  2. Open market picker and select TESTBTSHKD as a first asset
  3. See that you can't open market picker anymore

Expected behavior
User should have an ability to select trading pairs that can't be trade

Screenshots
marketPickerBug

Desktop (please complete the following information):

  • OS: Ubuntu 16.04.5 LTS
  • Browser Chrome
  • Version 72.0.3626.96
@sschiessl-bcp
Copy link
Contributor

Can it be that it's a prediction market asset?

@startailcoon
Copy link
Contributor

It's a prediction market, you can see it by the trading pair design. Ordinary markets have a / while a prediction market has a :.

Could be that we need to update this to make it possible to change the pair on PM as well.

@react-cat
Copy link
Contributor Author

@startailcoon @sschiessl-bcp I think we should do it, cause as for me, it was uncomfortable and confusing that after selecting this pair I could do anything and I need to manually remove pair from url and reload page to make market picker work again.

Anyone interested in this task ? If no one wants it, I could make it in 1 hour, but feel free to take it.

@startailcoon startailcoon added [1b] User Story The User Story details a requirement. It may ref a parent Project (Epic). It may ref child Task(s) [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [5a] Tiny Indicates size of task. Est. less than one hour labels Aug 12, 2019
@startailcoon startailcoon added this to the 190816 milestone Aug 12, 2019
@startailcoon startailcoon changed the title Market picker select nonexistent trading pair [1][react-cat] Market picker select nonexistent trading pair Aug 12, 2019
@startailcoon
Copy link
Contributor

startailcoon commented Aug 12, 2019

@startailcoon @sschiessl-bcp I think we should do it, cause as for me, it was uncomfortable and confusing that after selecting this pair I could do anything and I need to manually remove pair from url and reload page to make market picker work again.

Anyone interested in this task ? If no one wants it, I could make it in 1 hour, but feel free to take it.

Feel free to work on it :)

My only question is, should we make the user aware that they are on a Prediction Market and not an ordinary market pair somehow?

@react-cat
Copy link
Contributor Author

@startailcoon Maybe we could make some popup that will appear when user first time select prediction market. This way we can warn user that it is a prediction market, give a link where he can read more about prediction markets and it's differences from ordinary and of course a checkbox "never show again".
This could be a solution in case if you decide that we need to aware user.

And I have a question, what is that ?) Appears only on prediction market page
AwesomeScreenshot-wallet-bitshares-org--2019-08-13_8_50

@sschiessl-bcp
Copy link
Contributor

That is the "borrow & sell" button for prediction markets. I guess no one bothered to check it for new styling :)

@sschiessl-bcp
Copy link
Contributor

sschiessl-bcp commented Aug 13, 2019

As for the header, I agree that the header should be the same. Please check what extra special cases are in the header. As far as I remember its "only" that it allows only one market order (PREDICTION ASSET : ITS BACKING)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[1b] User Story The User Story details a requirement. It may ref a parent Project (Epic). It may ref child Task(s) [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [5a] Tiny Indicates size of task. Est. less than one hour
Projects
None yet
Development

No branches or pull requests

3 participants